Sign upLogin

ANSSI-FR/polichombr

View on GitHub
Star

Showing 1,243 of 1,244 total issues

Line is too long. [108/80]
Open

  if ((di.opcode.props[:setip] == true) || (di.opcode.props[:stopexec] == true)) && (movebpstack.length > 3)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Use snake_case for method names.
Open

def countSubCallTree(fromaddr, toaddr)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Rename is_looping to looping?.
Open

  def self.is_looping(di)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that predicates are named properly.

Example:

# bad
def is_even?(value)
end

# good
def even?(value)
end

# bad
def has_value?
end

# good
def value?
end

Use snake_case for variable names.
Open

      @fullFuncSign += currFunc
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all variables use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
fooBar = 1

# good
foo_bar = 1

Example: EnforcedStyle: camelCase

# bad
foo_bar = 1

# good
fooBar = 1

Line is too long. [166/80]
Open

                  ['sha256_h0', ["\x67\xe6\x09\x6a\x85\xae\x67\xbb\x72\xf3\x6e\x3c\x3a\xf5\x4f\xa5\x7f\x52\x0e\x51\x8c\x68\x05\x9b\xab\xd9\x83\x1f\x19\xcd\xe0\x5b"]],
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [199/80]
Open

                  ['ripe_md160', ["\x00\x00\x00\x00\x99\x79\x82\x5a\xa1\xeb\xd9\x6e\xdc\xbc\x1b\x8f\x4e\xfd\x53\xa9\xe6\x8b\xa2\x50\x24\xd1\x4d\x5c\xf3\x3e\x70\x6d\xe9\x76\x6d\x7a\x00\x00\x00\x00"]],
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [164/80]
Open

    while (defined?(di.block.from_normal.length) && !di.block.from_normal.empty?) || (defined?(di.block.from_subfuncret.length) && !di.block.from_subfuncret.empty?)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [152/80]
Open

      if di.block.list[0].block.from_normal.nil? && !di.block.list[0].block.from_subfuncret.nil? && (di.block.list[0].block.from_subfuncret.length == 1)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [131/80]
Open

  if di.instruction.to_s =~ /(IsDebuggerPresent|cmp .*, 0CCh|pop ss|SeDebugPrivilege|IsBadWritePtr)/ || (di.opcode.name == 'rtdsc')
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [98/80]
Open

  next unless (di.opcode.name == 'mov') && di.instruction.args.last.to_s =~ /^[(xref_|)0-9a-f]+h$/
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [110/80]
Open

            currFunc += ',' if (to_ref == @treetbfunc[y][0]) && (currFunc[-1] != ',') && (currFunc[-1] != ':')
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [84/80]
Open

                    return $gdasm.normalize(di.block.list[i].instruction.args.first)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [138/80]
Open

          puts "    [+] Pattern found at 0x#{(secAddr + i + pattAddr).to_s(16)} fast disassembling in process..." if defined?($VERBOSEOPT)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [81/80]
Open

    strings << [di.address, argStr.gsub(/[\x0d]/n, '\\r').gsub(/[\x0a]/n, '\\n')]
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [97/80]
Open

          log("  * #{PoliUtils.poliLinkAddr(ref_from)} call #{PoliUtils.poliLinkAddr(orifunc)}.")
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Use snake_case for variable names.
Open

    @fullHashSign = ''
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all variables use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
fooBar = 1

# good
foo_bar = 1

Example: EnforcedStyle: camelCase

# bad
foo_bar = 1

# good
fooBar = 1

Line is too long. [438/80]
Open

                  ['md5_T', ["\x78\xa4\x6a\xd7\x56\xb7\xc7\xe8\xdb\x70\x20\x24\xee\xce\xbd\xc1\xaf\x0f\x7c\xf5\x2a\xc6\x87\x47\x13\x46\x30\xa8\x01\x95\x46\xfd\xd8\x98\x80\x69\xaf\xf7\x44\x8b\xb1\x5b\xff\xff\xbe\xd7\x5c\x89\x22\x11\x90\x6b\x93\x71\x98\xfd\x8e\x43\x79\xa6\x21\x08\xb4\x49\x62\x25\x1e\xf6\x40\xb3\x40\xc0\x51\x5a\x5e\x26\xaa\xc7\xb6\xe9\x5d\x10\x2f\xd6\x53\x14\x44\x02\x81\xe6\xa1\xd8\xc8\xfb\xd3\xe7\xe6\xcd\xe1\x21\xd6"]],
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [110/80]
Open

  next unless (secAddr <= dasm.decoded.first[0]) && ((secAddr + secDatas.data.length) > dasm.decoded.first[0])
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Use snake_case for variable names.
Open

      currFunc = ''
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all variables use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
fooBar = 1

# good
foo_bar = 1

Example: EnforcedStyle: camelCase

# bad
foo_bar = 1

# good
fooBar = 1

Line is too long. [85/80]
Open

        strings << [di.address, argStr.gsub(/[\x0d]/n, '\\r').gsub(/[\x0a]/n, '\\n')]
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop
Severity
Category
Status
Source
Language