Sign upLogin

ANSSI-FR/polichombr

View on GitHub
Star

Showing 1,243 of 1,244 total issues

Line is too long. [84/80]
Open

        @tbComments[caddr] = "Builded string : \\\"#{cstring.gsub("\n", '\\n')}\\\""
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [86/80]
Open

    log("\nPattern affected to #{name} found at #{PoliUtils.poliLinkAddr(pattAddr)}.")
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [91/80]
Open

  if defined?(di.block) && defined?(di.block.list[0]) && defined?(di.block.list[0].address)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Rename is_modrm to modrm?.
Open

  def self.is_modrm(arg)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that predicates are named properly.

Example:

# bad
def is_even?(value)
end

# good
def even?(value)
end

# bad
def has_value?
end

# good
def value?
end

Use snake_case for variable names.
Open

cryptoPatterns = [['AES_forward_box', ["\x63\x7c\x77\x7b\xf2\x6b\x6f\xc5\x30\x01\x67\x2b\xfe\xd7\xab\x76", "\xca\x82\xc9\x7d\xfa\x59\x47\xf0\xad\xd4\xa2\xaf\x9c\xa4\x72\xc0", "\xb7\xfd\x93\x26\x36\x3f\xf7\xcc\x34\xa5\xe5\xf1\x71\xd8\x31\x15", "\x04\xc7\x23\xc3\x18\x96\x05\x9a\x07\x12\x80\xe2\xeb\x27\xb2\x75", "\x09\x83\x2c\x1a\x1b\x6e\x5a\xa0\x52\x3b\xd6\xb3\x29\xe3\x2f\x84", "\x53\xd1\x00\xed\x20\xfc\xb1\x5b\x6a\xcb\xbe\x39\x4a\x4c\x58\xcf", "\xd0\xef\xaa\xfb\x43\x4d\x33\x85\x45\xf9\x02\x7f\x50\x3c\x9f\xa8", "\x51\xa3\x40\x8f\x92\x9d\x38\xf5\xbc\xb6\xda\x21\x10\xff\xf3\xd2", "\xcd\x0c\x13\xec\x5f\x97\x44\x17\xc4\xa7\x7e\x3d\x64\x5d\x19\x73", "\x60\x81\x4f\xdc\x22\x2a\x90\x88\x46\xee\xb8\x14\xde\x5e\x0b\xdb", "\xe0\x32\x3a\x0a\x49\x06\x24\x5c\xc2\xd3\xac\x62\x91\x95\xe4\x79", "\xe7\xc8\x37\x6d\x8d\xd5\x4e\xa9\x6c\x56\xf4\xea\x65\x7a\xae\x08", "\xba\x78\x25\x2e\x1c\xa6\xb4\xc6\xe8\xdd\x74\x1f\x4b\xbd\x8b\x8a", "\x70\x3e\xb5\x66\x48\x03\xf6\x0e\x61\x35\x57\xb9\x86\xc1\x1d\x9e", "\xe1\xf8\x98\x11\x69\xd9\x8e\x94\x9b\x1e\x87\xe9\xce\x55\x28\xdf", "\x8c\xa1\x89\x0d\xbf\xe6\x42\x68\x41\x99\x2d\x0f\xb0\x54\xbb\x16"]],
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all variables use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
fooBar = 1

# good
foo_bar = 1

Example: EnforcedStyle: camelCase

# bad
foo_bar = 1

# good
fooBar = 1

Use snake_case for variable names.
Open

        currFunc += ';'
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all variables use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
fooBar = 1

# good
foo_bar = 1

Example: EnforcedStyle: camelCase

# bad
foo_bar = 1

# good
fooBar = 1

Line is too long. [98/80]
Open

        strArg = $gdasm.read_raw_data(carg, 0x10).unpack('C*').map { |a| '\\x' + a.to_s(16) }.join
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [135/80]
Open

        $gdasm.xrefs[di.instruction.args.last.symbolic.target.bind.reduce] = [di.instruction.args.last.symbolic.target.bind.reduce, di]
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [135/80]
Open

          if dasm.di_at(secAddr + i + pattAddr).block.from_subfuncret.nil? && dasm.di_at(secAddr + i + pattAddr).block.from_normal.nil?
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [101/80]
Open

  if str.downcase =~ /(http[s]{0,1}:\/\/|get |post |\/[a-z0-9\/.]{0,}\?[0-9a-z]+|http\/[0-9]\.[0-9])/
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Use snake_case for method names.
Open

def checkCall(strFunc, xrefCall)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Use snake_case for variable names.
Open

            currFunc += ',' if (to_ref == @treetbfunc[y][0]) && (currFunc[-1] != ',') && (currFunc[-1] != ':')
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all variables use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
fooBar = 1

# good
foo_bar = 1

Example: EnforcedStyle: camelCase

# bad
foo_bar = 1

# good
fooBar = 1

Line is too long. [166/80]
Open

                  ['sha224_h0', ["\xd8\x9e\x05\xc1\x07\xd5\x7c\x36\x17\xdd\x70\x30\x39\x59\x0e\xf7\x31\x0b\xc0\xff\x11\x15\x58\x68\xa7\x8f\xf9\x64\xa4\x4f\xfa\xbe"]],
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [84/80]
Open

                return $gdasm.normalize(di.block.list[i - 1].instruction.args.first)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [85/80]
Open

    label = $gdasm.get_label_at(di.instruction.args.last.symbolic.target.bind.reduce)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [82/80]
Open

        $gdasm.xrefs[di.instruction.args.last.symbolic.target.bind.reduce] |= [di]
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [115/80]
Open

      ctb[((sizeMax + tdi.instruction.args.first.symbolic.target.bind(ebp: 0).reduce)), strToInj.length] = strToInj
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Use snake_case for method names.
Open

def getFromFunc(addressFunc)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Use snake_case for method names.
Open

def calculateSizeSubCallTree(fromaddr, toaddr, indent, cnt)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Use snake_case for variable names.
Open

@IDAscript = ''
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all variables use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
fooBar = 1

# good
foo_bar = 1

Example: EnforcedStyle: camelCase

# bad
foo_bar = 1

# good
fooBar = 1
Severity
Category
Status
Source
Language