Sign upLogin

ANSSI-FR/polichombr

View on GitHub
Star

Showing 1,243 of 1,244 total issues

Use snake_case for variable names.
Open

    @fullFuncSign = ''
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all variables use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
fooBar = 1

# good
foo_bar = 1

Example: EnforcedStyle: camelCase

# bad
foo_bar = 1

# good
fooBar = 1

Line is too long. [90/80]
Open

      printSubCallTree(tdi_addr, toaddr, [[0, false]], countSubCallTree(tdi_addr, toaddr))
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [105/80]
Open

  if section.characteristics.include?('CONTAINS_CODE') || section.characteristics.include?('MEM_EXECUTE')
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [123/80]
Open

      if !argStr.nil? && (argStr.length > 4) && (argStr =~ regexStr || ((argStr.length > 5) && (argStr !~ /[\x80-\xff]/n)))
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [121/80]
Open

    if !argStr.nil? && (argStr.length > 4) && (argStr =~ regexStr || ((argStr.length > 5) && (argStr !~ /[\x80-\xff]/n)))
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [160/80]
Open

  if str.downcase =~ /(vmscsi\.sys|vmhgfs\.sys|vmx_svga\.sys|vmxnet\.sys|vmmouse\.sys|vmdebug\.sys|vmware|sbiedll|qemu|wine_get_unix_file_name|vbox|virtualbox)/
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Use snake_case for method names.
Open

def getToFunc(addressFunc)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Use snake_case for method names.
Open

def printCallTree(fromaddr, toaddr)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Rename is_linked_func to linked_func?.
Open

def is_linked_func(currFunc, start_address, stop_address)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that predicates are named properly.

Example:

# bad
def is_even?(value)
end

# good
def even?(value)
end

# bad
def has_value?
end

# good
def value?
end

Line is too long. [103/80]
Open

              printCallTree(dasm.normalize(ep), orifunc) if isFuncTreeLink(dasm.normalize(ep), orifunc)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [91/80]
Open

  if (di.opcode.name == 'push') && di.instruction.args.first.to_s =~ /^(xref_|)[0-9a-f]+h$/
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [95/80]
Open

  movebpstack = [] if (di.opcode.props[:setip] == true) || (di.opcode.props[:stopexec] == true)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Use snake_case for method names.
Open

def AddTagFunction(funcaddr, tagname)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Use snake_case for method names.
Open

  def self.getArg(addrori, arg)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Avoid more than 3 levels of block nesting.
Open

          while i > 0
            if di.block.list[i - 1].opcode.name == 'push'
              if carg == arg
                return $gdasm.normalize(di.block.list[i - 1].instruction.args.first)
              end
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

Avoid more than 3 levels of block nesting.
Open

              printCallTree(dasm.normalize(ep), orifunc) if isFuncTreeLink(dasm.normalize(ep), orifunc)
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

Avoid more than 3 levels of block nesting.
Open

          next unless addr == orifunc
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

This cop checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

Line is too long. [116/80]
Open

                  ['PKCS_sha256', ["\x30\x31\x30\x0d\x06\x09\x60\x86\x48\x01\x65\x03\x04\x02\x01\x05\x00\x04\x20"]],
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [492/80]
Open

                  ['PKCS_sha512', ["\x98\x2f\x8a\x42\x91\x44\x37\x71\xcf\xfb\xc0\xb5\xa5\xdb\xb5\xe9\x5b\xc2\x56\x39\xf1\x11\xf1\x59\xa4\x82\x3f\x92\xd5\x5e\x1c\xab\x98\xaa\x07\xd8\x01\x5b\x83\x12\xbe\x85\x31\x24\xc3\x7d\x0c\x55\x74\x5d\xbe\x72\xfe\xb1\xde\x80\xa7\x06\xdc\x9b\x74\xf1\x9b\xc1\xc1\x69\x9b\xe4\x86\x47\xbe\xef\xc6\x9d\xc1\x0f\xcc\xa1\x0c\x24\x6f\x2c\xe9\x2d\xaa\x84\x74\x4a\xdc\xa9\xb0\x5c\xda\x88\xf9\x76\x52\x51\x3e\x98\x6d\xc6\x31\xa8\xc8\x27\x03\xb0\xc7\x7f\x59\xbf\xf3"]],
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop

Line is too long. [489/80]
Open

                  ['rijndael_te1', ["\x63\x63\xc6\xa5\x7c\x7c\xf8\x84\x77\x77\xee\x99\x7b\x7b\xf6\x8d\xf2\xf2\xff\x0d\x6b\x6b\xd6\xbd\x6f\x6f\xde\xb1\xc5\xc5\x91\x54\x30\x30\x60\x50\x01\x01\x02\x03\x67\x67\xce\xa9\x2b\x2b\x56\x7d\xfe\xfe\xe7\x19\xd7\xd7\xb5\x62\xab\xab\x4d\xe6\x76\x76\xec\x9a\xca\xca\x8f\x45\x82\x82\x1f\x9d\xc9\xc9\x89\x40\x7d\x7d\xfa\x87\xfa\xfa\xef\x15\x59\x59\xb2\xeb\x47\x47\x8e\xc9\xf0\xf0\xfb\x0b\xad\xad\x41\xec\xd4\xd4\xb3\x67\xa2\xa2\x5f\xfd\xaf\xaf\x45\xea"]],
Severity: Minor
Found in polichombr/analysis_tools/AnalyzeIt.rb by rubocop
Severity
Category
Status
Source
Language