Sign upLogin

AOEpeople/StackFormation

View on GitHub
Star
src/StackFormation/Command/Blueprint/DeployCommand.php

Summary

Maintainability
D
2 days
Test Coverage

Function executeWithBlueprint has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

    protected function executeWithBlueprint(Blueprint $blueprint, InputInterface $input, OutputInterface $output)
    {
        $dryRun = $input->getOption('dryrun');
        if ($dryRun) {
            $formatter = new \Symfony\Component\Console\Helper\FormatterHelper();
Severity: Minor
Found in src/StackFormation/Command/Blueprint/DeployCommand.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method executeWithBlueprint has 122 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function executeWithBlueprint(Blueprint $blueprint, InputInterface $input, OutputInterface $output)
    {
        $dryRun = $input->getOption('dryrun');
        if ($dryRun) {
            $formatter = new \Symfony\Component\Console\Helper\FormatterHelper();
Severity: Major
Found in src/StackFormation/Command/Blueprint/DeployCommand.php - About 4 hrs to fix

    Method configure has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function configure()
    {
        $this
            ->setName('blueprint:deploy')
            ->setAliases(['deploy'])
    Severity: Minor
    Found in src/StackFormation/Command/Blueprint/DeployCommand.php - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                      case 'UPDATE_IN_PROGRESS':
                    if ($questionHelper->ask($input, $output, new ConfirmationQuestion('Stack is in UPDATE_IN_PROGRESS state. Do you want to cancel the current update and deploy then? [Y/n]'))) {
                        $output->writeln('Cancelling update for ' . $stackName);
                        $stack->cancelUpdate();
                        $observer = new Observer($stack, $stackFactory, $output);
      Severity: Major
      Found in src/StackFormation/Command/Blueprint/DeployCommand.php and 2 other locations - About 1 hr to fix
      src/StackFormation/Command/Blueprint/DeployCommand.php on lines 153..163
      src/StackFormation/Command/Blueprint/DeployCommand.php on lines 185..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                      case 'CREATE_FAILED':
                    if ($questionHelper->ask($input, $output, new ConfirmationQuestion('Stack is in CREATE_FAILED state. Do you want to delete it first? [Y/n]'))) {
                        $output->writeln('Deleting failed stack ' . $stackName);
                        $stack->delete();
                        $observer = new Observer($stack, $stackFactory, $output);
      Severity: Major
      Found in src/StackFormation/Command/Blueprint/DeployCommand.php and 2 other locations - About 1 hr to fix
      src/StackFormation/Command/Blueprint/DeployCommand.php on lines 174..184
      src/StackFormation/Command/Blueprint/DeployCommand.php on lines 185..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                      case 'UPDATE_ROLLBACK_FAILED':
                    if ($questionHelper->ask($input, $output, new ConfirmationQuestion('Stack is in UPDATE_ROLLBACK_FAILED state. Do you want to continue the update rollback and deploy then? [Y/n]'))) {
                        $output->writeln('Continuing update rollback for ' . $stackName);
                        $stack->continueUpdateRollback();
                        $observer = new Observer($stack, $stackFactory, $output);
      Severity: Major
      Found in src/StackFormation/Command/Blueprint/DeployCommand.php and 2 other locations - About 1 hr to fix
      src/StackFormation/Command/Blueprint/DeployCommand.php on lines 153..163
      src/StackFormation/Command/Blueprint/DeployCommand.php on lines 174..184

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status