Sign upLogin

Abhi347/NoobFileChooser

View on GitHub
Star

Showing 24 of 24 total issues

NoobFile has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

public class NoobFile {
    private String mName;
    private String mMimeType;
    private String mDocId;
    private Uri mUri;
Severity: Minor
Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/models/NoobFile.java - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package com.noob.noobfilechooser.adapters;

import android.support.v7.widget.RecyclerView;
import android.view.LayoutInflater;
import android.view.View;
    Severity: Major
    Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/adapters/NoobFileAdapter.java and 1 other location - About 2 hrs to fix
    noobfilechooser/src/main/java/com/noob/noobfilechooser/adapters/NoobDrawerAdapter.java on lines 1..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 170.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package com.noob.noobfilechooser.adapters;

import android.support.v7.widget.RecyclerView;
import android.view.LayoutInflater;
import android.view.View;
    Severity: Major
    Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/adapters/NoobDrawerAdapter.java and 1 other location - About 2 hrs to fix
    noobfilechooser/src/main/java/com/noob/noobfilechooser/adapters/NoobFileAdapter.java on lines 1..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 170.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    NoobFileActivity has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class NoobFileActivity extends AppCompatActivity implements NoobFileFragmentDelegate, NoobDrawerFragmentDelegate {

    @BindView(R2.id.drawer_noob_activity)
    protected DrawerLayout mDrawerLayout;
    Severity: Minor
    Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/NoobFileActivity.java - About 2 hrs to fix

      Method takePermission has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static boolean takePermission(final Activity activity, final String permission, final String rationaleMessage, final boolean shouldShowDialog) {
        if (checkPermission(activity, permission))
            return true;
        boolean shouldRequestPermission = true;
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M && shouldShowDialog && activity.shouldShowRequestPermissionRationale(permission)) {
      Severity: Minor
      Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobPermissionManager.java - About 1 hr to fix

        Method initializeRecyclerView has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected void initializeRecyclerView() {

        turnOnMultiSelectMode(false);

        mFileRecyclerView.setHasFixedSize(true);
        Severity: Minor
        Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/fragments/NoobFileFragment.java - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public void setListener(OnRecyclerViewItemClick<NoobStorage> listenerParam) {
        mListener = listenerParam;
        mParent.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View viewParam) {
          Severity: Major
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/viewmodels/NoobDrawerViewHolder.java and 1 other location - About 1 hr to fix
          noobfilechooser/src/main/java/com/noob/noobfilechooser/viewmodels/NoobFileViewHolder.java on lines 30..50

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public void setListener(OnRecyclerViewItemClick<NoobFile> listenerParam) {
        mListener = listenerParam;
        mParent.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View viewParam) {
          Severity: Major
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/viewmodels/NoobFileViewHolder.java and 1 other location - About 1 hr to fix
          noobfilechooser/src/main/java/com/noob/noobfilechooser/viewmodels/NoobDrawerViewHolder.java on lines 30..50

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method getNameFromUri has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              @RequiresApi(api = Build.VERSION_CODES.LOLLIPOP)
    public static String getNameFromUri(Uri uri, Context context) {
        String title = null;
        if (isRootUri(uri)) {
            DocumentFile documentFile = DocumentFile.fromTreeUri(context, uri);
          Severity: Minor
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobSAFManager.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method renameTo has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public boolean renameTo(String fileName) {
        if (getDocumentFile() != null) {
            boolean success = getDocumentFile().renameTo(fileName);
            if (success)
                mIsInvalid = true;
          Severity: Minor
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/models/NoobFile.java - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method onActivityResult has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    protected void onActivityResult(int requestCode, int resultCode, Intent data) {
        if (resultCode == RESULT_OK) {
            boolean result = false;
            if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.LOLLIPOP) {
          Severity: Minor
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/NoobFileActivity.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public NoobFileViewHolder(View itemView) {
        super(itemView);
        mParent = itemView;
        mTitleText = (TextView) itemView.findViewById(R.id.item_name);
        mFileImageView = (ImageView) itemView.findViewById(R.id.item_image);
          Severity: Minor
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/viewmodels/NoobFileViewHolder.java and 1 other location - About 45 mins to fix
          noobfilechooser/src/main/java/com/noob/noobfilechooser/viewmodels/NoobDrawerViewHolder.java on lines 23..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public NoobDrawerViewHolder(View itemView) {
        super(itemView);
        mParent = itemView;
        mTitleText = (TextView) itemView.findViewById(R.id.item_name);
        mStorageImageView = (ImageView) itemView.findViewById(R.id.item_image);
          Severity: Minor
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/viewmodels/NoobDrawerViewHolder.java and 1 other location - About 45 mins to fix
          noobfilechooser/src/main/java/com/noob/noobfilechooser/viewmodels/NoobFileViewHolder.java on lines 23..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static String getValidName(File file, boolean isRoot) {
        if (isRoot)
            if (NoobManager.getInstance().getConfig().isShouldShowStorageName()) {
                return "Internal Storage ( " + file.getName() + " )";
            } else {
          Severity: Minor
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobFileManager.java and 1 other location - About 35 mins to fix
          noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobSAFManager.java on lines 160..169

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static String getValidName(DocumentFile file, boolean isRoot) {
        if (isRoot)
            if (NoobManager.getInstance().getConfig().isShouldShowStorageName()) {
                return "SD Card ( " + file.getName() + " )";
            } else {
          Severity: Minor
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobSAFManager.java and 1 other location - About 35 mins to fix
          noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobFileManager.java on lines 44..53

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  Cursor childCursor = contentResolver.query(childrenUri, new String[]{
                DocumentsContract.Document.COLUMN_DISPLAY_NAME, DocumentsContract.Document.COLUMN_MIME_TYPE, DocumentsContract.Document.COLUMN_DOCUMENT_ID}, null, null, null);
          Severity: Minor
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobSAFManager.java and 1 other location - About 30 mins to fix
          noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobSAFManager.java on lines 117..118

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  Cursor docCursor = contentResolver.query(docUri, new String[]{
                DocumentsContract.Document.COLUMN_DISPLAY_NAME, DocumentsContract.Document.COLUMN_MIME_TYPE, DocumentsContract.Document.COLUMN_DOCUMENT_ID}, null, null, null);
          Severity: Minor
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobSAFManager.java and 1 other location - About 30 mins to fix
          noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobSAFManager.java on lines 138..139

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      else if (NoobManager.getInstance().getConfig().isShouldShowStorageName()) {
                title = "SD Card ( " + documentFile.getName() + " )";
            } else {
                title = "SD Card";
            }
          Severity: Minor
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobSAFManager.java and 1 other location - About 30 mins to fix
          noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobSAFManager.java on lines 87..91

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (NoobManager.getInstance().getConfig().isShouldShowStorageName()) {
                    title = "Internal Storage ( " + documentFile.getName() + " )";
                } else {
                    title = "Internal Storage";
                }
          Severity: Minor
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobSAFManager.java and 1 other location - About 30 mins to fix
          noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobSAFManager.java on lines 92..96

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this method.
          Open

                  return NoobManager.getInstance().getConfig().getFileDrawableResource();
          Severity: Major
          Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/models/NoobFile.java - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language