Sign upLogin

Abhi347/NoobFileChooser

View on GitHub
Star

Showing 24 of 24 total issues

Method getChildren has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public List<NoobFile> getChildren() {
        List<NoobFile> children = new ArrayList<>();
        if (getDocumentFile() != null) {
            DocumentFile[] _files = getDocumentFile().listFiles();
            for (DocumentFile docFile : _files) {
Severity: Minor
Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/models/NoobFile.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addStorage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean addStorage(NoobStorage storage) {
        if (mNoobStorageList != null) {
            for (NoobStorage store : mNoobStorageList) {
                if (storage.toString().equalsIgnoreCase(store.toString())) {
                    store.load(storage);
Severity: Minor
Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/managers/NoobPrefsManager.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadImage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean loadImage(ImageView imageView) {
        if (mThumbnail == null && isImageFile()) {
            if (mDocumentFile != null)
                loadThumbnailSAF(imageView.getContext());
            else
Severity: Minor
Found in noobfilechooser/src/main/java/com/noob/noobfilechooser/models/NoobFile.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

      <window_info id="TODO" active="false" anchor="bottom" auto_hide="false" internal_type="DOCKED" type="DOCKED" visible="false" show_stripe_button="true" weight="0.33" sideWeight="0.5" order="6" side_tool="false" content_ui="tabs" />
Severity: Minor
Found in projectFilesBackup/.idea/workspace.xml by fixme
Severity
Category
Status
Source
Language