ActivityWatch/aw-webui

View on GitHub
src/queries.ts

Summary

Maintainability
C
1 day
Test Coverage

File queries.ts has 356 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import _ from 'lodash';

// TODO: Sanitize string input of buckets

function querystr_to_array(querystr: string): string[] {
Severity: Minor
Found in src/queries.ts - About 4 hrs to fix

    Function canonicalEvents has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    export function canonicalEvents(params: DesktopQueryParams | AndroidQueryParams): string {
      // Needs escaping for regex patterns like '\w' to work (JSON.stringify adds extra unecessary escaping)
      const categories_str = params.categories
        ? JSON.stringify(params.categories).replace(/\\\\/g, '\\')
        : '';
    Severity: Minor
    Found in src/queries.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function canonicalEvents has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function canonicalEvents(params: DesktopQueryParams | AndroidQueryParams): string {
      // Needs escaping for regex patterns like '\w' to work (JSON.stringify adds extra unecessary escaping)
      const categories_str = params.categories
        ? JSON.stringify(params.categories).replace(/\\\\/g, '\\')
        : '';
    Severity: Minor
    Found in src/queries.ts - About 1 hr to fix

      Function fullDesktopQuery has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function fullDesktopQuery(params: DesktopQueryParams): string[] {
        return querystr_to_array(
          `
          ${canonicalEvents({
            ...params,
      Severity: Minor
      Found in src/queries.ts - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status