Sign upLogin

Admidio/admidio

View on GitHub
Star
adm_program/system/classes/ComponentUpdate.php

Summary

Maintainability
C
1 day
Test Coverage

Function update has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function update(string $targetVersion)
    {
        global $gLogger;

        $currentVersionArray = self::getVersionArrayFromVersion($this->getValue('com_version'));
Severity: Minor
Found in adm_program/system/classes/ComponentUpdate.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function executeStep has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    private function executeStep(SimpleXMLElement $xmlNode, string $version = '')
    {
        global $gLogger;

        $updateStepContent = trim((string) $xmlNode);
Severity: Minor
Found in adm_program/system/classes/ComponentUpdate.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function update(string $targetVersion)
    {
        global $gLogger;

        $currentVersionArray = self::getVersionArrayFromVersion($this->getValue('com_version'));
Severity: Minor
Found in adm_program/system/classes/ComponentUpdate.php - About 1 hr to fix

    Method executeStep has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function executeStep(SimpleXMLElement $xmlNode, string $version = '')
    {
        global $gLogger;

        $updateStepContent = trim((string) $xmlNode);
    Severity: Minor
    Found in adm_program/system/classes/ComponentUpdate.php - About 1 hr to fix

      Function getMaxUpdateStep has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getMaxUpdateStep(): int
    {
        $maxUpdateStep = 0;
        $currentVersionArray = self::getVersionArrayFromVersion($this->getValue('com_version'));
      Severity: Minor
      Found in adm_program/system/classes/ComponentUpdate.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getXmlObject has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getXmlObject(int $mainVersion, int $minorVersion): SimpleXMLElement
    {
        global $gLogger;

        // update of Admidio core has another path for the xml files as plugins
      Severity: Minor
      Found in adm_program/system/classes/ComponentUpdate.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status