Sign upLogin

AlchemyCMS/alchemy_cms

View on GitHub
Star
app/serializers/alchemy/page_tree_serializer.rb

Summary

Maintainability
B
5 hrs
Test Coverage
A
97%

Method pages has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def pages
      tree = []
      path = [{id: object.parent_id, children: tree}]
      page_list = object.self_and_descendants.includes(:public_version, {language: :site})
      base_level = object.level - 1
Severity: Minor
Found in app/serializers/alchemy/page_tree_serializer.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method page_hash has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def page_hash(page, level, folded)
      p_hash = {
        id: page.id,
        name: page.name,
        public: page.public?,
Severity: Minor
Found in app/serializers/alchemy/page_tree_serializer.rb - About 1 hr to fix

    Method pages has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def pages
      tree = []
      path = [{id: object.parent_id, children: tree}]
      page_list = object.self_and_descendants.includes(:public_version, {language: :site})
      base_level = object.level - 1
    Severity: Minor
    Found in app/serializers/alchemy/page_tree_serializer.rb - About 1 hr to fix

      Method page_hash has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def page_hash(page, level, folded)
      p_hash = {
        id: page.id,
        name: page.name,
        public: page.public?,
      Severity: Minor
      Found in app/serializers/alchemy/page_tree_serializer.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status