Sign upLogin

AlchemyCMS/alchemy_cms

View on GitHub
Star
lib/alchemy/test_support/having_picture_thumbnails_examples.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

File having_picture_thumbnails_examples.rb has 537 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

RSpec.shared_examples_for "having picture thumbnails" do
  it "should not store negative values for crop values" do
    record.crop_from = "-1x100"
    record.crop_size = "-20x30"
    record.save
Severity: Major
Found in lib/alchemy/test_support/having_picture_thumbnails_examples.rb - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Wontfix

              context "and aspect ratio set" do
            let(:settings) do
              {fixed_ratio: "0.5"}
            end
    Severity: Minor
    Found in lib/alchemy/test_support/having_picture_thumbnails_examples.rb and 1 other location - About 30 mins to fix
    lib/alchemy/test_support/having_picture_thumbnails_examples.rb on lines 474..481

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Wontfix

              context "and aspect ratio set" do
            let(:settings) do
              {fixed_ratio: "2"}
            end
    Severity: Minor
    Found in lib/alchemy/test_support/having_picture_thumbnails_examples.rb and 1 other location - About 30 mins to fix
    lib/alchemy/test_support/having_picture_thumbnails_examples.rb on lines 487..494

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status