Sign upLogin

Alvaro2112/Money_run

View on GitHub
Star
app/src/main/java/sdp/moneyrun/game/Game.java

Summary

Maintainability
D
1 day
Test Coverage
B
89%

File Game.java has 434 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package sdp.moneyrun.game;


import android.app.Activity;
import android.content.Intent;
Severity: Minor
Found in app/src/main/java/sdp/moneyrun/game/Game.java - About 6 hrs to fix

    Game has 40 methods (exceeds 20 allowed). Consider refactoring.
    Open

    @SuppressWarnings("FieldCanBeLocal")
public class Game {

    private final String DATABASE_GAME = "games";
    private final String DATABASE_PLAYER = "players";
    Severity: Minor
    Found in app/src/main/java/sdp/moneyrun/game/Game.java - About 5 hrs to fix

      Method endGame has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static void endGame(int numberOfCollectedCoins, int score, String playerId, @NonNull List<Player> players, @NonNull Activity currentActivity, boolean hasDied) {
      Severity: Minor
      Found in app/src/main/java/sdp/moneyrun/game/Game.java - About 45 mins to fix

        Method setPlayers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public void setPlayers(@Nullable List<Player> players, boolean forceLocal, @NonNull OnCompleteListener listener) {
        if (players == null) {
            throw new IllegalArgumentException("players should not be null.");
        }
        if (players.isEmpty()) {
        Severity: Minor
        Found in app/src/main/java/sdp/moneyrun/game/Game.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status