Sign upLogin

AndyObtiva/glimmer-dsl-libui

View on GitHub
Star
examples/timer2.rb

Summary

Maintainability
C
1 day
Test Coverage

Method setup_timer has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

  def setup_timer
    unless @setup_timer
      Glimmer::LibUI.timer(1) do
        if @started
          seconds = @sec_spinbox.value
Severity: Minor
Found in examples/timer2.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_gui has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create_gui
    window('Timer') {
      margined true
      
      group('Countdown') {
Severity: Minor
Found in examples/timer2.rb - About 1 hr to fix

    Method setup_timer has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def setup_timer
    unless @setup_timer
      Glimmer::LibUI.timer(1) do
        if @started
          seconds = @sec_spinbox.value
    Severity: Minor
    Found in examples/timer2.rb - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                    if hours > 0
                @hour_spinbox.value = hours -= 1
                @min_spinbox.value = minutes = MINUTE_MAX
                @sec_spinbox.value = seconds = SECOND_MAX
              end
      Severity: Major
      Found in examples/timer2.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                      if hours == 0 && minutes == 0 && seconds == 0
                @start_button.enabled = true
                @stop_button.enabled = false
                @started = false
                unless @played
        Severity: Major
        Found in examples/timer2.rb - About 45 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            def play_alarm
    stop_alarm
    if @pid.nil?
      begin
        @pid = spawn "timidity -G 0.0-10.0 #{@alarm_file}"
          Severity: Minor
          Found in examples/timer2.rb and 1 other location - About 15 mins to fix
          examples/timer.rb on lines 28..36

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status