Sign upLogin

AndyObtiva/glimmer-dsl-swt

View on GitHub
Star
lib/glimmer/swt/custom/refined_table.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method configure_sorting has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

        def configure_sorting
          @table_proxy.sort_strategy = lambda do
            new_sort = @table_proxy.sort_block || @table_proxy.sort_by_block || @table_proxy.sort_property
            new_sort_direction = @table_proxy.sort_direction
            return if new_sort == @last_sort && new_sort_direction == @last_sort_direction
Severity: Minor
Found in lib/glimmer/swt/custom/refined_table.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method pagination has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def pagination
          composite {
            layout_data(:fill, :center, true, false)
            
            fill_layout(:horizontal) {
Severity: Major
Found in lib/glimmer/swt/custom/refined_table.rb - About 2 hrs to fix

    Method configure_sorting has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def configure_sorting
          @table_proxy.sort_strategy = lambda do
            new_sort = @table_proxy.sort_block || @table_proxy.sort_by_block || @table_proxy.sort_property
            new_sort_direction = @table_proxy.sort_direction
            return if new_sort == @last_sort && new_sort_direction == @last_sort_direction
    Severity: Minor
    Found in lib/glimmer/swt/custom/refined_table.rb - About 1 hr to fix

      Method corrected_page has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def corrected_page(initial_page_value = nil)
          correct_page = initial_page_value || page
          correct_page = [correct_page, page_count].min
          correct_page = [correct_page, 1].max
          correct_page = (filtered_model_array&.count.to_i > 0) ? (correct_page > 0 ? correct_page : 1) : 0
      Severity: Minor
      Found in lib/glimmer/swt/custom/refined_table.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method restore_query_page has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def restore_query_page
          new_query = query.to_s.strip
          last_query = @last_query.to_s.strip
          if last_query != new_query
            query_to_page_hash[last_query] = page
      Severity: Minor
      Found in lib/glimmer/swt/custom/refined_table.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  @first_button_proxy = button {
              text '<<'
              enabled <= [self, :page, on_read: ->(value) {value > first_page}]
              
              on_widget_selected do
      Severity: Minor
      Found in lib/glimmer/swt/custom/refined_table.rb and 1 other location - About 15 mins to fix
      lib/glimmer/swt/custom/refined_table.rb on lines 143..149

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  @previous_button_proxy = button {
              text '<'
              enabled <= [self, :page, on_read: ->(value) {value > first_page}]
              
              on_widget_selected do
      Severity: Minor
      Found in lib/glimmer/swt/custom/refined_table.rb and 1 other location - About 15 mins to fix
      lib/glimmer/swt/custom/refined_table.rb on lines 133..139

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  @next_button_proxy = button {
              text '>'
              enabled <= [self, :page, on_read: ->(value) {value < last_page}]
              
              on_widget_selected do
      Severity: Minor
      Found in lib/glimmer/swt/custom/refined_table.rb and 1 other location - About 15 mins to fix
      lib/glimmer/swt/custom/refined_table.rb on lines 103..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  @last_button_proxy = button {
              text '>>'
              enabled <= [self, :page, on_read: ->(value) {value < last_page}]
              
              on_widget_selected do
      Severity: Minor
      Found in lib/glimmer/swt/custom/refined_table.rb and 1 other location - About 15 mins to fix
      lib/glimmer/swt/custom/refined_table.rb on lines 93..99

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status