Sign upLogin

AndyObtiva/glimmer-dsl-swt

View on GitHub
Star
samples/elaborate/battleship/model/cell.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method place_ship! has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def place_ship!(ship)
        begin
          old_ship_top_left_cell = ship.top_left_cell
          old_ship_orientation = ship.orientation
          ship.top_left_cell = self
Severity: Minor
Found in samples/elaborate/battleship/model/cell.rb - About 1 hr to fix

    Method place_ship! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def place_ship!(ship)
        begin
          old_ship_top_left_cell = ship.top_left_cell
          old_ship_orientation = ship.orientation
          ship.top_left_cell = self
    Severity: Minor
    Found in samples/elaborate/battleship/model/cell.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status