Sign upLogin

AndyObtiva/glimmer-dsl-swt

View on GitHub
Star
samples/elaborate/tetris/model/tetromino.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Tetromino has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Tetromino
      ORIENTATIONS = [:north, :east, :south, :west]
      
      LETTER_COLORS = {
        I: :cyan,
Severity: Minor
Found in samples/elaborate/tetris/model/tetromino.rb - About 3 hrs to fix

    File tetromino.rb has 271 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require_relative 'block'

require 'matrix'

class Tetris
    Severity: Minor
    Found in samples/elaborate/tetris/model/tetromino.rb - About 2 hrs to fix

      Method default_blocks has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def default_blocks
        case @letter
        when :I
          [
            [block, block, block, block]
      Severity: Minor
      Found in samples/elaborate/tetris/model/tetromino.rb - About 1 hr to fix

        Method rotate! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

              def rotate!(direction)
        return if stopped?
        can_rotate = nil
        new_blocks = nil
        game.hypothetical do
        Severity: Minor
        Found in samples/elaborate/tetris/model/tetromino.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  left_most_blocks.any? { |left_most_block|
            (@row + left_most_block[:row_index]) >= 0 &&
              playfield[@row + left_most_block[:row_index]][@column + left_most_block[:column_index] - 1].occupied?
          }
        Severity: Minor
        Found in samples/elaborate/tetris/model/tetromino.rb and 1 other location - About 20 mins to fix
        samples/elaborate/tetris/model/tetromino.rb on lines 129..132

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  right_most_blocks.any? { |right_most_block|
            (@row + right_most_block[:row_index]) >= 0 &&
              playfield[@row + right_most_block[:row_index]][@column + right_most_block[:column_index] + 1].occupied?
          }
        Severity: Minor
        Found in samples/elaborate/tetris/model/tetromino.rb and 1 other location - About 20 mins to fix
        samples/elaborate/tetris/model/tetromino.rb on lines 154..157

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status