Sign upLogin

AndyObtiva/glimmer-dsl-swt

View on GitHub
Star
samples/hello/hello_refined_table.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method games has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def games
      if @games.nil?
        @games = []
        baseball_team_combinations = BaseballTeam.all.combination(2).to_a
        current_day = first_day
Severity: Minor
Found in samples/hello/hello_refined_table.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method all has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def all
        @all ||= [
          {town: 'Chicago', name: 'White Sox', ballpark: 'Guaranteed Rate Field'},
          {town: 'Cleveland', name: 'Indians', ballpark: 'Progressive Field'},
          {town: 'Detroit', name: 'Tigers', ballpark: 'Comerica Park'},
Severity: Minor
Found in samples/hello/hello_refined_table.rb - About 1 hr to fix

    Method games has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def games
      if @games.nil?
        @games = []
        baseball_team_combinations = BaseballTeam.all.combination(2).to_a
        current_day = first_day
    Severity: Minor
    Found in samples/hello/hello_refined_table.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status