Sign upLogin

AndyObtiva/glimmer-dsl-tk

View on GitHub
Star

Showing 117 of 117 total issues

Method interpret has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def interpret(parent, keyword, *args, &block)
          if args.first.is_a?(Hash)
            options = args.first.symbolize_keys
            options[:initialcolor] = options.delete(:initial_color) if options.keys.include?(:initial_color)
            options[:filetypes] = options.delete(:file_types) if options.keys.include?(:file_types)
Severity: Minor
Found in lib/glimmer/dsl/tk/built_in_dialog_expression.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method launch has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def launch
    root {
      title 'Hello, Checkbutton!'
      
      label {
Severity: Minor
Found in samples/hello/hello_checkbutton.rb - About 1 hr to fix

    Method set_attribute has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def set_attribute(attribute, *args)
        begin
          args = normalize_attribute_arguments(attribute, args)
          widget_custom_attribute = widget_custom_attribute_mapping[tk.class] && widget_custom_attribute_mapping[tk.class][attribute.to_s]
          if respond_to?(attribute_setter(attribute), super_only: true)
    Severity: Minor
    Found in lib/glimmer/tk/widget_proxy.rb - About 1 hr to fix

      Method show_find_dialog has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def show_find_dialog
    toplevel(@root) { |tl|
      title 'Find'
      
      label {
      Severity: Minor
      Found in samples/hello/hello_text.rb - About 1 hr to fix

        Method launch has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def launch
    root {
      title 'Hello, Frame!'
      
      frame { # frame simply contains widgets for visual organization via a layout
        Severity: Minor
        Found in samples/hello/hello_frame.rb - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              menu(label: 'Country', underline: 0) {
      ['denmark', 'finland', 'france', 'germany', 'italy', 'mexico', 'netherlands', 'norway', 'usa'].each do |image_name|
        menu_item(:radiobutton, label: image_name.capitalize) {
          selection image_name == 'usa'
          image File.expand_path("images/#{image_name}.png", __dir__)
          Severity: Major
          Found in samples/hello/hello_menu_bar.rb and 1 other location - About 1 hr to fix
          samples/hello/hello_contextual_menu.rb on lines 103..111

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              menu(label: 'Country', underline: 0) {
      ['denmark', 'finland', 'france', 'germany', 'italy', 'mexico', 'netherlands', 'norway', 'usa'].each do |image_name|
        menu_item(:radiobutton, label: image_name.capitalize) {
          selection image_name == 'usa'
          image File.expand_path("images/#{image_name}.png", __dir__)
          Severity: Major
          Found in samples/hello/hello_contextual_menu.rb and 1 other location - About 1 hr to fix
          samples/hello/hello_menu_bar.rb on lines 171..179

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method post_add_content has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def post_add_content
        if escapable?
           on('KeyPress') do |event|
            if event.state == 0 && event.keysym == 'Escape'
              tk.grab_release
          Severity: Minor
          Found in lib/glimmer/tk/toplevel_proxy.rb - About 1 hr to fix

            Method initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def initialize
      reset_activities!
      individual_observer = Glimmer::DataBinding::Observer.proc do
        unless @updating_group
          @updating_individual = true
            Severity: Minor
            Found in samples/hello/hello_checkbutton.rb - About 1 hr to fix

              Method handle_listener has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                    def handle_listener(listener_name, &listener)
        case listener_name.to_s.downcase
        when '<<modified>>', '<modified>', 'modified'
          modified_listener = Proc.new do |*args|
            @modified_count ||= 0
              Severity: Minor
              Found in lib/glimmer/tk/text_proxy.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  menu(label: 'Language', underline: 3) {
      ['denmark', 'finland', 'france', 'germany', 'italy', 'mexico', 'netherlands', 'norway', 'usa'].each do |image_name|
        menu_item(:radiobutton, label: image_name.capitalize) {
          selection image_name == 'usa'
          image File.expand_path("images/#{image_name}.png", __dir__)
              Severity: Major
              Found in samples/hello/hello_menu_bar.rb and 1 other location - About 1 hr to fix
              samples/hello/hello_contextual_menu.rb on lines 90..97

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  menu(label: 'Language', underline: 3) {
      ['denmark', 'finland', 'france', 'germany', 'italy', 'mexico', 'netherlands', 'norway', 'usa'].each do |image_name|
        menu_item(:radiobutton, label: image_name.capitalize) {
          selection image_name == 'usa'
          image File.expand_path("images/#{image_name}.png", __dir__)
              Severity: Major
              Found in samples/hello/hello_contextual_menu.rb and 1 other location - About 1 hr to fix
              samples/hello/hello_menu_bar.rb on lines 158..165

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method launch has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def launch
    root {
      title 'Hello, Spinbox!'
      
      label {
              Severity: Minor
              Found in samples/hello/hello_spinbox.rb - About 1 hr to fix

                Method handle_listener has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def handle_listener(listener_name, &listener)
        listener_name = listener_name.to_s
        # TODO return a listener registration object that has a deregister method
        if listener_name == 'destroy'
          # 'destroy' is a more reliable alternative listener binding to '<Destroy>'
                Severity: Minor
                Found in lib/glimmer/tk/widget_proxy.rb - About 1 hr to fix

                  Method show_find_dialog has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def show_find_dialog
    toplevel(@root) { |tl|
      title 'Find'
      
      label {
                  Severity: Minor
                  Found in samples/hello/hello_text.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method font= has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def font=(value)
        if (value.is_a?(Symbol) || value.is_a?(String)) && FONTS_PREDEFINED.include?(value.to_s.downcase)
          @tk.font = "tk_#{value}_font".camelcase(:upper)
        else
          @tk.font = value.is_a?(TkFont) ? value : TkFont.new(value)
                  Severity: Minor
                  Found in lib/glimmer/tk/widget_proxy.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method set_attribute has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        def set_attribute(attribute, *args)
        case attribute.to_s
        when 'yscrollbar'
          @yscrollbar = args.first
          if @yscrollbar == true
                  Severity: Minor
                  Found in lib/glimmer/tk/scrollbar_frame_proxy.rb - About 1 hr to fix

                    Method grid has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                          def grid(options = {})
        @_visible = true
        options = options.stringify_keys
        options['rowspan'] = options.delete('row_span') if options.keys.include?('row_span')
        options['columnspan'] = options.delete('column_span') if options.keys.include?('column_span')
                    Severity: Minor
                    Found in lib/glimmer/tk/widget_proxy.rb - About 1 hr to fix

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                          menu(label: 'Edit', underline: 0) {
      menu_item(label: 'Cut', underline: 2) {
        accelerator OS.mac? ? 'Command+X' : 'Control+X'
      }
                      Severity: Minor
                      Found in samples/hello/hello_contextual_menu.rb and 1 other location - About 1 hr to fix
                      samples/hello/hello_menu_bar.rb on lines 111..122

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 47.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                          menu(label: 'Edit', underline: 0) {
      menu_item(label: 'Cut', underline: 2) {
        accelerator OS.mac? ? 'Command+X' : 'Control+X'
      }
                      Severity: Minor
                      Found in samples/hello/hello_menu_bar.rb and 1 other location - About 1 hr to fix
                      samples/hello/hello_contextual_menu.rb on lines 43..54

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 47.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language