Sign upLogin

AndyObtiva/glimmer

View on GitHub
Star
lib/glimmer/data_binding/observable_hash.rb

Summary

Maintainability
B
5 hrs
Test Coverage

File observable_hash.rb has 274 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

require 'glimmer/data_binding/observable_hashable'
require 'glimmer/data_binding/observer'

module Glimmer
  module DataBinding
Severity: Minor
Found in lib/glimmer/data_binding/observable_hash.rb - About 2 hrs to fix

    Method transform_keys! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Wontfix

          def transform_keys!(hash2 = nil, &block)
        if hash2.nil? && block.nil?
          super
        else
          old_hash = self.dup
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_hash.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method keep_if has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Wontfix

          def keep_if(&block)
        if block_given?
          old_hash = self.dup
          super(&block).tap do |new_hash|
            deleted_keys = old_hash.keys - new_hash.keys
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_hash.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method filter! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Wontfix

          def filter!(&block)
        if block_given?
          old_hash = self.dup
          super(&block).tap do |new_hash|
            deleted_keys = old_hash.keys - new_hash.keys
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_hash.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method reject! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Wontfix

          def reject!(&block)
        if block_given?
          old_hash = self.dup
          super(&block).tap do |new_hash|
            deleted_keys = old_hash.keys - new_hash.keys
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_hash.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method delete_if has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Wontfix

          def delete_if(&block)
        if block_given?
          old_hash = self.dup
          super(&block).tap do |new_hash|
            deleted_keys = old_hash.keys - new_hash.keys
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_hash.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method select! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Wontfix

          def select!(&block)
        if block_given?
          old_hash = self.dup
          super(&block).tap do |new_hash|
            deleted_keys = old_hash.keys - new_hash.keys
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_hash.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method transform_values! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Wontfix

          def transform_values!(&block)
        if block_given?
          old_hash = self.dup
          super(&block).tap do |new_hash|
            new_hash.keys.each do |changed_key|
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_hash.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method merge! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Wontfix

          def merge!(*other_hashes, &block)
        if other_hashes.empty?
          super
        else
          old_hash = self.dup
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_hash.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          def delete_if(&block)
        if block_given?
          old_hash = self.dup
          super(&block).tap do |new_hash|
            deleted_keys = old_hash.keys - new_hash.keys
    Severity: Major
    Found in lib/glimmer/data_binding/observable_hash.rb and 4 other locations - About 50 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 159..175
    lib/glimmer/data_binding/observable_hash.rb on lines 178..194
    lib/glimmer/data_binding/observable_hash.rb on lines 197..213
    lib/glimmer/data_binding/observable_hash.rb on lines 216..232

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          def filter!(&block)
        if block_given?
          old_hash = self.dup
          super(&block).tap do |new_hash|
            deleted_keys = old_hash.keys - new_hash.keys
    Severity: Major
    Found in lib/glimmer/data_binding/observable_hash.rb and 4 other locations - About 50 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 140..156
    lib/glimmer/data_binding/observable_hash.rb on lines 159..175
    lib/glimmer/data_binding/observable_hash.rb on lines 197..213
    lib/glimmer/data_binding/observable_hash.rb on lines 216..232

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          def reject!(&block)
        if block_given?
          old_hash = self.dup
          super(&block).tap do |new_hash|
            deleted_keys = old_hash.keys - new_hash.keys
    Severity: Major
    Found in lib/glimmer/data_binding/observable_hash.rb and 4 other locations - About 50 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 140..156
    lib/glimmer/data_binding/observable_hash.rb on lines 159..175
    lib/glimmer/data_binding/observable_hash.rb on lines 178..194
    lib/glimmer/data_binding/observable_hash.rb on lines 197..213

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          def keep_if(&block)
        if block_given?
          old_hash = self.dup
          super(&block).tap do |new_hash|
            deleted_keys = old_hash.keys - new_hash.keys
    Severity: Major
    Found in lib/glimmer/data_binding/observable_hash.rb and 4 other locations - About 50 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 140..156
    lib/glimmer/data_binding/observable_hash.rb on lines 159..175
    lib/glimmer/data_binding/observable_hash.rb on lines 178..194
    lib/glimmer/data_binding/observable_hash.rb on lines 216..232

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          def select!(&block)
        if block_given?
          old_hash = self.dup
          super(&block).tap do |new_hash|
            deleted_keys = old_hash.keys - new_hash.keys
    Severity: Major
    Found in lib/glimmer/data_binding/observable_hash.rb and 4 other locations - About 50 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 140..156
    lib/glimmer/data_binding/observable_hash.rb on lines 178..194
    lib/glimmer/data_binding/observable_hash.rb on lines 197..213
    lib/glimmer/data_binding/observable_hash.rb on lines 216..232

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

              changed_keys = old_hash.keys + new_hash.keys
          changed_keys.each do |changed_key|
            old_value = old_hash[changed_key]
            if new_hash[changed_key] != old_value
              unregister_dependent_observers(changed_key, old_value)
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_hash.rb and 1 other location - About 25 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 292..298

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                changed_keys = old_hash.keys + new_hash.keys
            changed_keys.each do |changed_key|
              old_value = old_hash[changed_key]
              if new_hash[changed_key] != old_value
                unregister_dependent_observers(changed_key, old_value)
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_hash.rb and 1 other location - About 25 mins to fix
    lib/glimmer/data_binding/observable_hash.rb on lines 273..279

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status