Sign upLogin

AppStateESS/homestead

View on GitHub
Star
class/HousingApplication.php

Summary

Maintainability
F
4 days
Test Coverage

HousingApplication has 81 functions (exceeds 20 allowed). Consider refactoring.
Open

class HousingApplication {

    public $id = 0;

    public $term; // The term which this application is for
Severity: Major
Found in class/HousingApplication.php - About 1 day to fix

File HousingApplication.php has 661 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Homestead;

use \Homestead\Exception\DatabaseException;
Severity: Major
Found in class/HousingApplication.php - About 1 day to fix

Method getUnassignedFreshmenApplications has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getUnassignedFreshmenApplications($term, $gender)
    {
        $db = new PHPWS_DB('hms_new_application');
        $db->addWhere('student_type', 'F');
        $db->addWhere('term', $term);
Severity: Minor
Found in class/HousingApplication.php - About 1 hr to fix

Method getApplicationByUser has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getApplicationByUser($username, $term, $applicationType = null)
    {
        $db = new PHPWS_DB('hms_new_application');
        $db->addWhere('username', $username);
        $db->addWhere('term', $term);
Severity: Minor
Found in class/HousingApplication.php - About 1 hr to fix

Function getAllFreshmenApplications has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getAllFreshmenApplications($term)
    {
        $sem = Term::getTermSem($term);

        $db = new PHPWS_DB('hms_new_application');
Severity: Minor
Found in class/HousingApplication.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($term = null, $banner_id = null, $username = null, $gender = null, $student_type = null, $application_term = null, $cell_phone = null, $meal_plan = null, $international = null)
Severity: Major
Found in class/HousingApplication.php - About 1 hr to fix

Function getApplicationByUser has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getApplicationByUser($username, $term, $applicationType = null)
    {
        $db = new PHPWS_DB('hms_new_application');
        $db->addWhere('username', $username);
        $db->addWhere('term', $term);
Severity: Minor
Found in class/HousingApplication.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function stamp has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function stamp()
    {
        // Set the last modified time
        $this->setModifiedOn(time());
Severity: Minor
Found in class/HousingApplication.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getUnassignedFreshmenApplications has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getUnassignedFreshmenApplications($term, $gender)
    {
        $db = new PHPWS_DB('hms_new_application');
        $db->addWhere('student_type', 'F');
        $db->addWhere('term', $term);
Severity: Minor
Found in class/HousingApplication.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getAllApplicationsForStudent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getAllApplicationsForStudent(Student $student)
    {
        $db = new PHPWS_DB('hms_new_application');

        if (!isset($student) || empty($student) || is_null($student)) {
Severity: Minor
Found in class/HousingApplication.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                return "Unknown";
Severity: Major
Found in class/HousingApplication.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return "Open Waiting-list";
Severity: Major
Found in class/HousingApplication.php - About 30 mins to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        switch($result['application_type']) {
            case 'fall':
                $app = new FallApplication($result['id']);
                break;
            case 'spring':
Severity: Major
Found in class/HousingApplication.php and 1 other location - About 3 hrs to fix
class/HousingApplicationFactory.php on lines 96..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 143.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status