Sign upLogin

AppStateESS/homestead

View on GitHub
Star
class/RoomChangeRequestFactory.php

Summary

Maintainability
C
1 day
Test Coverage

Method getRoomChangesByFloor has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getRoomChangesByFloor($term, Array $floorList, Array $stateList)
    {
        $db = PdoFactory::getPdoInstance();

        $floorPlaceholders = array();
Severity: Minor
Found in class/RoomChangeRequestFactory.php - About 1 hr to fix

Method getRoomChangesNeedsApproval has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getRoomChangesNeedsApproval($term, Array $floorList)
    {
        $db = PdoFactory::getPdoInstance();

        $floorPlaceholders = array();
Severity: Minor
Found in class/RoomChangeRequestFactory.php - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function getPendingByStudent(Student $student, $term)
    {
        $db = PdoFactory::getPdoInstance();

        $query = "SELECT hms_room_change_curr_request.* FROM hms_room_change_curr_request
Severity: Major
Found in class/RoomChangeRequestFactory.php and 1 other location - About 3 hrs to fix
class/RoomChangeRequestFactory.php on lines 312..341

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 149.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function getRequestPendingCheckout(Student $student, $term)
    {
        $db = PdoFactory::getPdoInstance();

        $query = "SELECT hms_room_change_curr_request.* FROM hms_room_change_curr_request
Severity: Major
Found in class/RoomChangeRequestFactory.php and 1 other location - About 3 hrs to fix
class/RoomChangeRequestFactory.php on lines 75..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 149.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status