Sign upLogin

AppStateESS/homestead

View on GitHub
Star
class/Student.php

Summary

Maintainability
F
4 days
Test Coverage

Student has 71 functions (exceeds 20 allowed). Consider refactoring.
Open

class Student
{
    // TODO make these all private and make sure nothing breaks
    public $username;
    public $banner_id;
Severity: Major
Found in class/Student.php - About 1 day to fix

File Student.php has 473 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace Homestead;

class Student
{
Severity: Minor
Found in class/Student.php - About 7 hrs to fix

Function getComputedClass has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    public function getComputedClass($baseTerm)
    {

        // Break up the term and year
        $yr = floor($this->application_term / 100);
Severity: Minor
Found in class/Student.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getAddress has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function getAddress($type = null)
    {
        $pr_address = null;
        $ps_address = null;
Severity: Minor
Found in class/Student.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getAddress has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getAddress($type = null)
    {
        $pr_address = null;
        $ps_address = null;
Severity: Minor
Found in class/Student.php - About 1 hr to fix

Avoid too many return statements within this method.
Open

                return 'Re-admit';
Severity: Major
Found in class/Student.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return 'New non-degree';
Severity: Major
Found in class/Student.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

            return $ps_address;
Severity: Major
Found in class/Student.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

            return false;
Severity: Major
Found in class/Student.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return 'Unknown type: ' . $this->type;
Severity: Major
Found in class/Student.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return 'Graduate';
Severity: Major
Found in class/Student.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

            return CLASS_SENIOR;
Severity: Major
Found in class/Student.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return 'Specialist';
Severity: Major
Found in class/Student.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return false;
Severity: Major
Found in class/Student.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return 'Unknown class: ' . $this->getClass();
Severity: Major
Found in class/Student.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return 'Undeclared';
Severity: Major
Found in class/Student.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return 'Withdrawn';
Severity: Major
Found in class/Student.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return 'Unknown level ' . $this->getStudentLevel();
Severity: Major
Found in class/Student.php - About 30 mins to fix

Function getPrintableGender has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getPrintableGender()
    {
        $gender = $this->getGender();

        if ($gender === '' || is_null($gender)) {
Severity: Minor
Found in class/Student.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getPrintableGenderAbbreviation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getPrintableGenderAbbreviation()
    {
        $gender = $this->getGender();

        if ($gender === '' || is_null($gender)) {
Severity: Minor
Found in class/Student.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getFullName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getFullName()
    {
        if (isset($this->preferred_name) && $this->preferred_name != '') {
            $firstName = $this->getPreferredName();
            if (isset($this->middle_name) && $this->middle_name != $this->preferred_name) {
Severity: Minor
Found in class/Student.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        } else if ($this->application_term >= $baseTerm) {
            // The application term is greater than the current term, then they're certainly a freshmen
            return CLASS_FRESHMEN;
        } else if (
                ($yr == $curr_year + 1 && $sem = 10) || ($yr == $curr_year && $sem >= 20 && $sem <= 40)) {
Severity: Major
Found in class/Student.php and 1 other location - About 4 hrs to fix
class/HMS_Lottery.php on lines 495..510

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 175.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status