Sign upLogin

Arie/tf2_line_parser

View on GitHub
Star

Showing 17 of 17 total issues

Method initialize has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def initialize(time, player_name, player_steamid, player_team, target_name, target_steamid, target_team, value, weapon, airshot)
Severity: Major
Found in lib/tf2_line_parser/events/airshot.rb - About 1 hr to fix

    Method initialize has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def initialize(time, player_name, player_steamid, player_team, target_name, target_steamid, target_team, value, weapon)
    Severity: Major
    Found in lib/tf2_line_parser/events/headshot_damage.rb - About 1 hr to fix

      Method initialize has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def initialize(time, player_name, player_steam_id, player_team, target_name, target_steam_id, target_team, weapon, customkill)
      Severity: Major
      Found in lib/tf2_line_parser/events/kill.rb - About 1 hr to fix

        Method initialize has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def initialize(time, player_name, player_steamid, player_team, target_name, target_steamid, target_team, value, weapon)
        Severity: Major
        Found in lib/tf2_line_parser/events/damage.rb - About 1 hr to fix

          Method initialize has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def initialize(time, player_name, player_steam_id, player_team, target_name, target_steam_id, target_team, healing, ubercharge)
          Severity: Major
          Found in lib/tf2_line_parser/events/medic_death.rb - About 1 hr to fix

            Method initialize has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def initialize(time, player_name, player_steam_id, player_team, target_name, target_steam_id, target_team, value)
            Severity: Major
            Found in lib/tf2_line_parser/events/heal.rb - About 1 hr to fix

              Method initialize has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    def initialize(time, player_name, player_steam_id, player_team, target_name, target_steam_id, target_team)
              Severity: Major
              Found in lib/tf2_line_parser/events/pvp_event.rb - About 50 mins to fix

                Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      def initialize(time, player_name, player_steam_id, player_team, cap_number, cap_name)
                Severity: Minor
                Found in lib/tf2_line_parser/events/capture_block.rb - About 45 mins to fix

                  Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        def initialize(time, player_name, player_steam_id, player_team, message)
                  Severity: Minor
                  Found in lib/tf2_line_parser/events/disconnect.rb - About 35 mins to fix

                    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                          def initialize(time, player_name, player_steam_id, player_team, item = self.class.item)
                    Severity: Minor
                    Found in lib/tf2_line_parser/events/player_action_event.rb - About 35 mins to fix

                      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                            def initialize(time, player_name, player_steam_id, player_team, message)
                      Severity: Minor
                      Found in lib/tf2_line_parser/events/chat.rb - About 35 mins to fix

                        Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                              def initialize(time, player_name, player_steam_id, player_team, message)
                        Severity: Minor
                        Found in lib/tf2_line_parser/events/connect.rb - About 35 mins to fix

                          Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def parse
      Events::Event.types.each do |type|
        begin
          match = line.match(type.regex)
        rescue ArgumentError
                          Severity: Minor
                          Found in lib/tf2_line_parser/line.rb - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                def self.regex
        @regex ||= /#{regex_time} #{regex_player} triggered "damage" #{regex_damage_against}\(damage "(?'value'\d+)"\)(?:( #{regex_realdamage})?( #{regex_weapon})?( #{regex_airshot})?)$/.freeze
      end
                          Severity: Minor
                          Found in lib/tf2_line_parser/events/airshot.rb and 1 other location - About 15 mins to fix
                          lib/tf2_line_parser/events/headshot_damage.rb on lines 6..8

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 26.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                def self.regex
        @regex ||= /#{regex_time} #{regex_player} triggered "damage" #{regex_damage_against}\(damage "(?'value'\d+)"\)(?:( #{regex_realdamage})?( #{regex_weapon})?) #{regex_headshot}$/.freeze
      end
                          Severity: Minor
                          Found in lib/tf2_line_parser/events/headshot_damage.rb and 1 other location - About 15 mins to fix
                          lib/tf2_line_parser/events/airshot.rb on lines 6..8

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 26.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            module Events
    class RoundWin < RoundEventWithVariables
      def self.round_type
        @round_type ||= 'Round_Win'
      end
                          Severity: Minor
                          Found in lib/tf2_line_parser/events/round_win.rb and 1 other location - About 15 mins to fix
                          lib/tf2_line_parser/events/round_length.rb on lines 4..16

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 25.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            module Events
    class RoundLength < RoundEventWithVariables
      def self.round_type
        @round_type ||= 'Round_Length'
      end
                          Severity: Minor
                          Found in lib/tf2_line_parser/events/round_length.rb and 1 other location - About 15 mins to fix
                          lib/tf2_line_parser/events/round_win.rb on lines 4..16

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 25.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language