ArtifactForms/MeshLibCore

View on GitHub

Showing 407 of 407 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  public Vector2f subtractLocal(Vector2f v) {
    if (null == v) {
      return null;
    }
    x -= v.x;
Severity: Minor
Found in src/main/java/math/Vector2f.java and 2 other locations - About 30 mins to fix
src/main/java/math/Vector2f.java on lines 290..297
src/main/java/math/Vector2f.java on lines 537..544

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  public Vector2f addLocal(Vector2f v) {
    if (null == v) {
      return null;
    }
    x += v.x;
Severity: Minor
Found in src/main/java/math/Vector2f.java and 2 other locations - About 30 mins to fix
src/main/java/math/Vector2f.java on lines 537..544
src/main/java/math/Vector2f.java on lines 673..680

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      min.set(
          Math.min(min.getX(), vertex.getX()),
          Math.min(min.getY(), vertex.getY()),
          Math.min(min.getZ(), vertex.getZ()));
Severity: Minor
Found in src/main/java/mesh/util/MeshBoundsCalculator.java and 1 other location - About 30 mins to fix
src/main/java/mesh/util/MeshBoundsCalculator.java on lines 31..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    return "SpotLight [angle="
        + angle
        + ", concentration="
        + concentration
        + ", position="
Severity: Minor
Found in src/main/java/engine/scene/light/SpotLight.java and 1 other location - About 30 mins to fix
src/main/java/engine/Timer.java on lines 254..264

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      max.set(
          Math.max(max.getX(), vertex.getX()),
          Math.max(max.getY(), vertex.getY()),
          Math.max(max.getZ(), vertex.getZ()));
Severity: Minor
Found in src/main/java/mesh/util/MeshBoundsCalculator.java and 1 other location - About 30 mins to fix
src/main/java/mesh/util/MeshBoundsCalculator.java on lines 27..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  public Vector2f multLocal(Vector2f v) {
    if (null == v) {
      return null;
    }
    x *= v.x;
Severity: Minor
Found in src/main/java/math/Vector2f.java and 2 other locations - About 30 mins to fix
src/main/java/math/Vector2f.java on lines 290..297
src/main/java/math/Vector2f.java on lines 673..680

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

                return false;
Severity: Major
Found in src/main/java/mesh/util/Bounds3.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

        if (toIndex != other.toIndex) return false;
    Severity: Major
    Found in src/main/java/mesh/Edge3D.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return false;
      Severity: Major
      Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return false;
        Severity: Major
        Found in src/main/java/mesh/util/Bounds3.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return true;
          Severity: Major
          Found in src/main/java/mesh/Edge3D.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return true;
            Severity: Major
            Found in src/main/java/mesh/util/Bounds3.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return true;
              Severity: Major
              Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    if (Float.floatToIntBits(y) != Float.floatToIntBits(other.y)) return false;
                Severity: Major
                Found in src/main/java/math/Vector2f.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return false;
                  Severity: Major
                  Found in src/main/java/mesh/util/Bounds3.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return false;
                    Severity: Major
                    Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return false;
                      Severity: Major
                      Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return false;
                        Severity: Major
                        Found in src/main/java/mesh/modifier/subdivision/DooSabinModifier.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return true;
                          Severity: Major
                          Found in src/main/java/math/Matrix3f.java - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                return true;
                            Severity: Major
                            Found in src/main/java/math/Vector2f.java - About 30 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language