Asymptix/Framework

View on GitHub

Showing 720 of 720 total issues

The method http_redirect is not named in camelCase.
Open

    public static function http_redirect($url, $params = [], $session = false) {
        $paramsString = "";
        foreach ($params as $key => $value) {
            $paramsString.= "&" . $key . "=" . $value;
        }
Severity: Minor
Found in framework/web/Http.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _get is not named in camelCase.
Open

    public static function _get($ip, $type, $provider) {
        if (!filter_var($ip, FILTER_VALIDATE_IP)) {
            throw new LocationDetectorException("Invalid IP address.");
        }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _max is not named in camelCase.
Open

    public static function _max($field, $conditions = [], $debug = false) {
        $dbQuery = (new DBPreparedQuery())->prepare(
            "SELECT MAX(`" . $field . "`) as 'val' FROM " . static::TABLE_NAME,
            $conditions
        );
Severity: Minor
Found in framework/db/DBObject.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _select is not named in camelCase.
Open

    public static function _select($conditions = []) {
        $ref = new \ReflectionClass(get_called_class());
        $dbObject = $ref->newInstance();

        return $dbObject->initQuery(DBQueryType::SELECT, $conditions);
Severity: Minor
Found in framework/db/DBObject.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method __filter is not named in camelCase.
Open

    private function __filter(DBObject $dbObject) {
        return ($dbObject->getFieldValue($this->field) == $this->value);
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _count is not named in camelCase.
Open

    public static function _count($conditions = [], $debug = false) {
        $dbQuery = (new DBPreparedQuery())->prepare(
            "SELECT COUNT(*) as 'val' FROM " . static::TABLE_NAME,
            $conditions
        );
Severity: Minor
Found in framework/db/DBObject.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _filter is not named in camelCase.
Open

    public static function _filter($filterName, $defaultValue) {
        return Tools::getFilterValue($filterName, $defaultValue);
    }
Severity: Minor
Found in framework/web/Request.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _post is not named in camelCase.
Open

    public static function _post($fieldName, $defaultValue = null) {
        $fieldValue = self::getFieldValue($fieldName, Http::POST);
        if (is_null($fieldValue) && !is_null($defaultValue)) {
            return $defaultValue;
        }
Severity: Minor
Found in framework/web/Request.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method __map is not named in camelCase.
Open

    private function __map(DBObject $dbObject) {
        if (empty($this->fields)) {
            return $dbObject->getFieldsList();
        }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method __map is not named in camelCase.
Open

    private function __map(DBObject $dbObject) {
        return $dbObject->getFieldValue($this->field);
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

TODO found
Open

    protected $fieldsAliases = []; // TODO: fill fields aliases if needed
Severity: Minor
Found in generators/templates/bean.tpl by fixme

TODO found
Open

namespace db; // TODO: change on needed namespace
Severity: Minor
Found in generators/templates/bean.tpl by fixme

TODO found
Open

class {{CLASS_NAME}} /* TODO: change class name (from plural to singular number for example) */ extends \Asymptix\db\DBObject {
Severity: Minor
Found in generators/templates/bean.tpl by fixme

TODO found
Open

 * TODO: change class description
Severity: Minor
Found in generator by fixme

TODO found
Open

            //TODO: implement other statuses
Severity: Minor
Found in framework/web/Http.php by fixme

TODO found
Open

    //TODO: clear other secured data from session
Severity: Minor
Found in modules/session.php by fixme

TODO found
Open

            //TODO: add all conditions from http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html
Severity: Minor
Found in framework/db/DBQueryCondition.php by fixme

TODO found
Open

 * TODO: change class description
Severity: Minor
Found in generators/templates/bean.tpl by fixme

TODO found
Open

    protected $fieldsAliases = []; // TODO: fill fields aliases if needed
Severity: Minor
Found in generator by fixme

TODO found
Open

            return false; //TODO: maybe verify if duplicate or other error
Severity: Minor
Found in classes/db/access/User.php by fixme
Severity
Category
Status
Source
Language