Showing 102 of 124 total issues
Function ParseConfig has 133 lines of code (exceeds 50 allowed). Consider refactoring. Open
func ParseConfig(conf *Config) {
// The use of FlagSet allows us to parse config multiple times, which is useful for unit tests.
flagSet := flag.NewFlagSet("AutoSpotting", flag.ExitOnError)
File autoscaling.go has 526 lines of code (exceeds 500 allowed). Consider refactoring. Open
// Copyright (c) 2016-2022 Cristian Măgherușan-Stanciu
// Licensed under the Open Software License version 3.0
package autospotting
autoScalingGroup has 23 methods (exceeds 20 allowed). Consider refactoring. Open
type autoScalingGroup struct {
*autoscaling.Group
name string
region *regionMethod AutoSpotting.handleNewOnDemandInstanceLaunch has 56 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (a *AutoSpotting) handleNewOnDemandInstanceLaunch(r *region, i *instance) error {
var spotInstanceID *string
var err error
if !i.shouldBeReplacedWithSpot() {Method instance.getCompatibleSpotInstanceTypesList has 53 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (i *instance) getCompatibleSpotInstanceTypesList(PrioritizationBias string, allowedList []string,
disallowedList []string) ([]*string, error) {
current := i.typeInfo
var acceptableInstanceTypes []acceptableInstance
Method AutoSpotting.handleLifecycleHookEvent has 9 return statements (exceeds 4 allowed). Open
func (a *AutoSpotting) handleLifecycleHookEvent(event events.CloudWatchEvent) error {
var ctEvent CloudTrailEvent
// Try to parse the event.Detail as Cloudwatch Event Rule
if err := json.Unmarshal(event.Detail, &ctEvent); err != nil {Method autoScalingGroup.loadLaunchTemplate has 8 return statements (exceeds 4 allowed). Open
func (a *autoScalingGroup) loadLaunchTemplate() (*launchTemplate, error) {
//already done
if a.launchTemplate != nil {
return a.launchTemplate, nil
}Method AutoSpotting.handleNewOnDemandInstanceLaunch has 8 return statements (exceeds 4 allowed). Open
func (a *AutoSpotting) handleNewOnDemandInstanceLaunch(r *region, i *instance) error {
var spotInstanceID *string
var err error
if !i.shouldBeReplacedWithSpot() {Method AutoSpotting.handleNewInstanceLaunch has 7 return statements (exceeds 4 allowed). Open
func (a *AutoSpotting) handleNewInstanceLaunch(regionName string, instanceID string, state string) error {
r := ®ion{name: regionName, conf: a.config, services: connections{}}
if !r.enabled() {
return fmt.Errorf("region %s is not enabled", regionName)Method autoScalingGroup.findDeployment has 5 return statements (exceeds 4 allowed). Open
func (a *autoScalingGroup) findDeployment(hookName string) (*string, *string, error) {
apps, err := a.region.services.codedeploy.ListApplications(&codedeploy.ListApplicationsInput{})
if err != nil {Method autoScalingGroup.getInstance has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring. Open
func (a *autoScalingGroup) getInstance(
availabilityZone *string,
onDemand bool,
considerInstanceProtection bool,
) *instance {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
2: cannot find package "github.com/AutoSpotting/AutoSpotting/core" in any of: Open
autospotting "github.com/AutoSpotting/AutoSpotting/core"- Exclude checks
Line length Open
If missing, the type is autodetected frome each ASG based on it's Launch Configuration.- Read upRead up
- Exclude checks
MD013 - Line length
Tags: line_length
Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)
This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.
This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.
You also have the option to exclude this rule for code blocks and tables. To
do this, set the code_blocks and/or tables parameters to false.
Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.
Line length Open
| Run on multiple regions | :white_check_mark: (default: all)| :heavy_minus_sign: |- Read upRead up
- Exclude checks
MD013 - Line length
Tags: line_length
Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)
This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.
This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.
You also have the option to exclude this rule for code blocks and tables. To
do this, set the code_blocks and/or tables parameters to false.
Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.
Line length Open
| Blacklisting of certain instance types | :white_check_mark: | :white_check_mark: |- Read upRead up
- Exclude checks
MD013 - Line length
Tags: line_length
Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)
This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.
This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.
You also have the option to exclude this rule for code blocks and tables. To
do this, set the code_blocks and/or tables parameters to false.
Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.
Line length Open
with comprehensive support and additional features geared towards production usage at scale.- Read upRead up
- Exclude checks
MD013 - Line length
Tags: line_length
Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)
This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.
This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.
You also have the option to exclude this rule for code blocks and tables. To
do this, set the code_blocks and/or tables parameters to false.
Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.
Line length Open
- automated instance type selection for Spot diversification without configuration changes from a standard OnDemand setup, and no vendor lock-in- Read upRead up
- Exclude checks
MD013 - Line length
Tags: line_length
Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)
This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.
This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.
You also have the option to exclude this rule for code blocks and tables. To
do this, set the code_blocks and/or tables parameters to false.
Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.
Inline HTML Open
<img src="logo.png" width="150" align="right">- Read upRead up
- Exclude checks
MD033 - Inline HTML
Tags: html
Aliases: no-inline-html
This rule is triggered whenever raw HTML is used in a markdown document:
Inline HTML header
To fix this, use 'pure' markdown instead of including raw HTML:
# Markdown headerRationale: Raw HTML is allowed in markdown, but this rule is included for those who want their documents to only include "pure" markdown, or for those who are rendering markdown documents in something other than HTML.
Line length Open
| [Works with Elastic Beanstalk](https://github.com/AutoSpotting/AutoSpotting/blob/053135e97082511fb99b689dce4a7a7830f3327c/START.md#for-elastic-beanstalk) | :white_check_mark: |- Read upRead up
- Exclude checks
MD013 - Line length
Tags: line_length
Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)
This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.
This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.
You also have the option to exclude this rule for code blocks and tables. To
do this, set the code_blocks and/or tables parameters to false.
Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.
Line length Open
| Auto-update instance type information | If using attribute based selection | ❌ | Optional |- Read upRead up
- Exclude checks
MD013 - Line length
Tags: line_length
Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)
This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.
This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.
You also have the option to exclude this rule for code blocks and tables. To
do this, set the code_blocks and/or tables parameters to false.
Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.