Sign upLogin

AutoSpotting/AutoSpotting

View on GitHub
Star

Showing 11 of 124 total issues

Function ParseConfig has 133 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func ParseConfig(conf *Config) {

    // The use of FlagSet allows us to parse config multiple times, which is useful for unit tests.
    flagSet := flag.NewFlagSet("AutoSpotting", flag.ExitOnError)
Severity: Major
Found in core/config.go - About 4 hrs to fix

    File autoscaling.go has 526 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    // Copyright (c) 2016-2022 Cristian Măgherușan-Stanciu
// Licensed under the Open Software License version 3.0

package autospotting
    Severity: Minor
    Found in core/autoscaling.go - About 2 hrs to fix

      autoScalingGroup has 23 methods (exceeds 20 allowed). Consider refactoring.
      Open

      type autoScalingGroup struct {
    *autoscaling.Group

    name                string
    region              *region
      Severity: Minor
      Found in core/autoscaling.go - About 2 hrs to fix

        Method AutoSpotting.handleNewOnDemandInstanceLaunch has 56 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (a *AutoSpotting) handleNewOnDemandInstanceLaunch(r *region, i *instance) error {
    var spotInstanceID *string
    var err error

    if !i.shouldBeReplacedWithSpot() {
        Severity: Minor
        Found in core/main.go - About 1 hr to fix

          Method instance.getCompatibleSpotInstanceTypesList has 53 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (i *instance) getCompatibleSpotInstanceTypesList(PrioritizationBias string, allowedList []string,
    disallowedList []string) ([]*string, error) {
    current := i.typeInfo
    var acceptableInstanceTypes []acceptableInstance
          Severity: Minor
          Found in core/instance_queries.go - About 1 hr to fix

            Method AutoSpotting.handleLifecycleHookEvent has 9 return statements (exceeds 4 allowed).
            Open

            func (a *AutoSpotting) handleLifecycleHookEvent(event events.CloudWatchEvent) error {
    var ctEvent CloudTrailEvent

    // Try to parse the event.Detail as Cloudwatch Event Rule
    if err := json.Unmarshal(event.Detail, &ctEvent); err != nil {
            Severity: Major
            Found in core/main.go - About 55 mins to fix

              Method autoScalingGroup.loadLaunchTemplate has 8 return statements (exceeds 4 allowed).
              Open

              func (a *autoScalingGroup) loadLaunchTemplate() (*launchTemplate, error) {
    //already done
    if a.launchTemplate != nil {
        return a.launchTemplate, nil
    }
              Severity: Major
              Found in core/autoscaling.go - About 50 mins to fix

                Method AutoSpotting.handleNewOnDemandInstanceLaunch has 8 return statements (exceeds 4 allowed).
                Open

                func (a *AutoSpotting) handleNewOnDemandInstanceLaunch(r *region, i *instance) error {
    var spotInstanceID *string
    var err error

    if !i.shouldBeReplacedWithSpot() {
                Severity: Major
                Found in core/main.go - About 50 mins to fix

                  Method AutoSpotting.handleNewInstanceLaunch has 7 return statements (exceeds 4 allowed).
                  Open

                  func (a *AutoSpotting) handleNewInstanceLaunch(regionName string, instanceID string, state string) error {
    r := &region{name: regionName, conf: a.config, services: connections{}}

    if !r.enabled() {
        return fmt.Errorf("region %s is not enabled", regionName)
                  Severity: Major
                  Found in core/main.go - About 45 mins to fix

                    Method autoScalingGroup.findDeployment has 5 return statements (exceeds 4 allowed).
                    Open

                    func (a *autoScalingGroup) findDeployment(hookName string) (*string, *string, error) {

    apps, err := a.region.services.codedeploy.ListApplications(&codedeploy.ListApplicationsInput{})

    if err != nil {
                    Severity: Major
                    Found in core/autoscaling.go - About 35 mins to fix

                      Method autoScalingGroup.getInstance has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                      Open

                      func (a *autoScalingGroup) getInstance(
    availabilityZone *string,
    onDemand bool,
    considerInstanceProtection bool,
) *instance {
                      Severity: Minor
                      Found in core/autoscaling.go - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language