BAN-AI-Communications/k95-mingw

View on GitHub
k95source/ckctel.c

Summary

Maintainability
Test Coverage

Showing 19 of 19 total issues

Either the condition cmd==200 is redundant, otherwise there is negative array index -51.
Open

if (tncnts[index][m] > MAXTNCNT) {
Severity: Minor
Found in k95source/ckctel.c and 2 other locations by cppcheck
k95source/ckctel.c on lines 746..746
k95source/ckctel.c on lines 753..753

Either the condition (cmd)==200 is redundant, otherwise there is negative array index -51.
Open

if (tncnts[index][m] > MAXTNCNT) {
Severity: Minor
Found in k95source/ckctel.c and 2 other locations by cppcheck
k95source/ckctel.c on lines 746..746
k95source/ckctel.c on lines 753..753

XXX found
Open

/* XXX maybe we should have some retry handling if not the whole first
Severity: Minor
Found in k95source/ckctel.c by fixme

XXX found
Open

debug(F101,"tn_ini switching from XXX to Telnet","",ttnproto);
Severity: Minor
Found in k95source/ckctel.c by fixme

BUG found
Open

int tn_sb_bug = 1; /* Telnet BUG - SB w/o WILL or DO */
Severity: Minor
Found in k95source/ckctel.c by fixme

BUG found
Open

int tn_auth_krb5_des_bug = 1; /* Telnet BUG - AUTH KRB5 DES */
Severity: Minor
Found in k95source/ckctel.c by fixme

Too many #ifdef configurations - cppcheck only checks 12 of 389 configurations. Use --force to check all configurations.
Open

#endif /* TNCODE */
Severity: Info
Found in k95source/ckctel.c by cppcheck

The scope of the variable x can be reduced.
Open

int x = 0;
Severity: Minor
Found in k95source/ckctel.c by cppcheck

The scope of the variable x can be reduced.
Open

int x;
Severity: Minor
Found in k95source/ckctel.c by cppcheck

Local variable i shadows outer variable
Open

int i;
Severity: Minor
Found in k95source/ckctel.c and 1 other location by cppcheck
k95source/ckctel.c on lines 3633..3633

The scope of the variable alias can be reduced.
Open

static int alias = -1; /* which alias are we using ? */
Severity: Minor
Found in k95source/ckctel.c by cppcheck

The scope of the variable ch can be reduced.
Open

int ch = 0, count = 0;
Severity: Minor
Found in k95source/ckctel.c by cppcheck

The scope of the variable y can be reduced.
Open

int c, x, y, n, m, flag;
Severity: Minor
Found in k95source/ckctel.c by cppcheck

Consecutive return, break, continue, goto or throw statements are unnecessary.
Open

break;
Severity: Minor
Found in k95source/ckctel.c by cppcheck

Local variable sb_out shadows outer variable
Open

CHAR sb_out[24]; /* multiple threads */
Severity: Minor
Found in k95source/ckctel.c and 1 other location by cppcheck
k95source/ckctel.c on lines 200..200

Variable ttn is assigned a value that is never used.
Open

ttn = (char *)sb_out; /* Point back to beginning */
Severity: Minor
Found in k95source/ckctel.c by cppcheck

Local variable local shadows outer variable
Open

extern int ckxech, local;
Severity: Minor
Found in k95source/ckctel.c and 1 other location by cppcheck
k95source/ckctel.c on lines 205..205

The function tn_get_display is never used.
Open

tn_get_display()
Severity: Minor
Found in k95source/ckctel.c by cppcheck

The function tn_flui is never used.
Open

tn_flui() {
Severity: Minor
Found in k95source/ckctel.c by cppcheck
Category
Status