Sign upLogin

BUTR/Bannerlord.BLSE

View on GitHub
Star

Showing 240 of 240 total issues

Avoid too many return statements within this method.
Open

        return false;
Severity: Major
Found in src/Bannerlord.BLSE.Shared/Utils/UacHelper.cs - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return Assembly.LoadFrom(assembly);
    Severity: Major
    Found in src/Bannerlord.BLSE/Features/AssemblyResolver/AssemblyResolverFeature.cs - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return;
      Severity: Major
      Found in src/Bannerlord.LauncherEx/ViewModels/BUTRLauncherOptionsVM.cs - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return;
        Severity: Major
        Found in src/Bannerlord.LauncherEx/ViewModels/BUTRLauncherOptionsVM.cs - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return null;
          Severity: Major
          Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return ResolveLauncherExAssemblies(assemblyName);
            Severity: Major
            Found in src/Bannerlord.BLSE.Loaders.LauncherEx/ModuleInitializer.cs - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return;
              Severity: Major
              Found in src/Bannerlord.LauncherEx/ViewModels/BUTRLauncherOptionsVM.cs - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return null;
                Severity: Major
                Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return;
                  Severity: Major
                  Found in src/Bannerlord.LauncherEx/ViewModels/BUTRLauncherOptionsVM.cs - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return Assembly.LoadFrom(assemblyFile);
                    Severity: Major
                    Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return false;
                      Severity: Major
                      Found in src/Bannerlord.BLSE/Features/ContinueSaveFile/Patches/SandBoxSubModulePatch.cs - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return true;
                        Severity: Major
                        Found in src/Bannerlord.LauncherEx/Extensions/ViewModelExtensions.cs - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return;
                          Severity: Major
                          Found in src/Bannerlord.LauncherEx/ViewModels/BUTRLauncherOptionsVM.cs - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return null;
                            Severity: Major
                            Found in src/Bannerlord.BLSE.Shared/Utils/UacHelper.cs - About 30 mins to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      var res1 = harmony.TryPatch(
            AccessTools2.DeclaredConstructor(typeof(ViewModel)),
            prefix: AccessTools2.DeclaredMethod(typeof(ViewModelPatch), nameof(ViewModelCtorPrefix)));
                              Severity: Minor
                              Found in src/Bannerlord.LauncherEx/Patches/ViewModelPatch.cs and 1 other location - About 30 mins to fix
                              src/Bannerlord.BLSE/Features/Xbox/Patches/ModulePatch.cs on lines 21..23

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 60.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                      var res4 = harmony.TryPatch(
            AccessTools2.Method(typeof(BrushFactory), "LoadBrushes"),
            AccessTools2.DeclaredMethod(typeof(BrushFactoryManager), nameof(LoadBrushesPostfix)));
                              Severity: Minor
                              Found in src/Bannerlord.LauncherEx/ResourceManagers/BrushFactoryManager.cs and 2 other locations - About 30 mins to fix
                              src/Bannerlord.LauncherEx/Patches/WidgetPrefabPatch.cs on lines 96..98
                              src/Bannerlord.LauncherEx/ResourceManagers/BrushFactoryManager.cs on lines 72..74

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 60.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                      var res2 = harmony.TryCreateReversePatcher(
            AccessTools2.DeclaredMethod(typeof(WidgetPrefab), "LoadFrom"),
            AccessTools2.DeclaredMethod(typeof(WidgetPrefabPatch), nameof(LoadFromDocument)));
                              Severity: Minor
                              Found in src/Bannerlord.LauncherEx/Patches/WidgetPrefabPatch.cs and 2 other locations - About 30 mins to fix
                              src/Bannerlord.LauncherEx/ResourceManagers/BrushFactoryManager.cs on lines 72..74
                              src/Bannerlord.LauncherEx/ResourceManagers/BrushFactoryManager.cs on lines 77..79

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 60.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                      var res3 = harmony.TryPatch(
            AccessTools2.DeclaredMethod(typeof(BrushFactory), "GetBrush"),
            AccessTools2.DeclaredMethod(typeof(BrushFactoryManager), nameof(GetBrushPrefix)));
                              Severity: Minor
                              Found in src/Bannerlord.LauncherEx/ResourceManagers/BrushFactoryManager.cs and 2 other locations - About 30 mins to fix
                              src/Bannerlord.LauncherEx/Patches/WidgetPrefabPatch.cs on lines 96..98
                              src/Bannerlord.LauncherEx/ResourceManagers/BrushFactoryManager.cs on lines 77..79

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 60.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      var res1 = harmony.TryPatch(
            AccessTools2.Constructor(typeof(Module)),
            prefix: AccessTools2.Method(typeof(ModulePatch), nameof(ShowedLoginScreenPrefix)));
                              Severity: Minor
                              Found in src/Bannerlord.BLSE/Features/Xbox/Patches/ModulePatch.cs and 1 other location - About 30 mins to fix
                              src/Bannerlord.LauncherEx/Patches/ViewModelPatch.cs on lines 19..21

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 60.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Method ReadLine8bpp has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                              Open

                                      private void ReadLine8bpp(SimpleBinaryStream input, PipelineWriter output, byte[] buffer)
        {
            var normalized = true;
            switch (format)
            {
                              Severity: Minor
                              Found in src/Bannerlord.LauncherEx/TPac/TextureUtils.cs - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language