Sign upLogin

BathHacked/energy-sparks

View on GitHub
Star
app/components/meter_costs_table_component.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class MeterCostsTableComponent has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

class MeterCostsTableComponent < ViewComponent::Base
  # Monthly costs: a hash of Date (first day of month) => Costs::MeterMonth
  # Change in costs: a hash of Date (first day of month) => change in total cost for month (£)
  # id: HTML id of the table
  # year_header: display year header row in table
Severity: Minor
Found in app/components/meter_costs_table_component.rb - About 3 hrs to fix

    Method bill_component_row has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def bill_component_row(component:)
    # early return if we don't have any of these components
    return unless bill_component?(component: component)

    total = 0.0
    Severity: Minor
    Found in app/components/meter_costs_table_component.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status