Sign upLogin

BathHacked/energy-sparks

View on GitHub
Star
app/controllers/schools/charts_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage
A
90%

Method render_json has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def render_json
    @chart_type ||= begin
      params.require(:chart_type).to_sym
    rescue => error
      render json: { error: error, status: 400 }.to_json and return
Severity: Minor
Found in app/controllers/schools/charts_controller.rb - About 1 hr to fix

    Method render_json has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def render_json
    @chart_type ||= begin
      params.require(:chart_type).to_sym
    rescue => error
      render json: { error: error, status: 400 }.to_json and return
    Severity: Minor
    Found in app/controllers/schools/charts_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status