app/models/school_time.rb
Method no_overlaps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def no_overlaps
return unless self.opening_time.present? && self.closing_time.present?
errors.add(:overlapping_time, 'Community use periods cannot overlap the school day') if usage_type == 'community_use' && overlaps_school_day?
errors.add(:overlapping_time, 'Periods cannot overlap each other') if overlaps_other?
end- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method overlapping has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def overlapping(usage_type)
day = overlapping_days
calendar_period = overlapping_calendar_periods
overlapping = false
school.school_times.each do |other|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"