Sign upLogin

BathHacked/energy-sparks

View on GitHub
Star
app/services/mailchimp_subscriber.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method subscribe has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def subscribe(user)
    list = @mailchimp_api.list_with_interests
    if list
      config = mailchimp_signup_params(user, list)
      if config.valid?
Severity: Minor
Found in app/services/mailchimp_subscriber.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_interests has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def find_interests(user, list)
    ret = {}
    items = []
    items << user.school_group_name if user.school_group_name
    items << user.staff_role.title if user.staff_role
Severity: Minor
Found in app/services/mailchimp_subscriber.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status