BathHacked/energy-sparks

View on GitHub

Showing 162 of 288 total issues

Class School has 79 methods (exceeds 20 allowed). Consider refactoring.
Open

class School < ApplicationRecord
  extend FriendlyId
  include EnergyTariffHolder
  include ParentMeterAttributeHolder

Severity: Major
Found in app/models/school.rb - About 1 day to fix

    Class ChartDataValues has 51 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class ChartDataValues
      attr_reader :anaylsis_type, :title, :subtitle, :chart1_type, :chart1_subtype,
                  :y_axis_label, :x_axis_label, :x_axis_categories, :x_max_value, :x_min_value,
                  :advice_header, :advice_footer, :y2_axis_label, :y2_point_format, :y2_max, :x_axis_ranges, :annotations,
                  :transformations, :allowed_operations, :drilldown_available, :parent_timescale_description,
    Severity: Major
    Found in app/models/chart_data_values.rb - About 7 hrs to fix

      File school.rb has 456 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'securerandom'
      
      class School < ApplicationRecord
        extend FriendlyId
        include EnergyTariffHolder
      Severity: Minor
      Found in app/models/school.rb - About 6 hrs to fix

        File application_helper.rb has 445 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        module ApplicationHelper
          include Pagy::Frontend
        
          def nice_date_times(datetime, options = {})
            return '' if datetime.nil?
        Severity: Minor
        Found in app/helpers/application_helper.rb - About 6 hrs to fix

          Method initialize has 151 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def initialize(user)
              user ||= User.new # guest user (not logged in)
              alias_action :create, :read, :update, :destroy, to: :crud
          
              # all users can do these things
          Severity: Major
          Found in app/models/ability.rb - About 6 hrs to fix

            Class BaseloadService has 35 methods (exceeds 20 allowed). Consider refactoring.
            Open

                class BaseloadService < BaseService
                  include AnalysableMixin
            
                  def enough_data?
                    baseload_service.enough_data?
            Severity: Minor
            Found in app/services/schools/advice/baseload_service.rb - About 4 hrs to fix

              File analysis.js has 335 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              "use strict";
              
              function updateDynamicTitles(titleWrapper, chartData) {
                var titleH3 = titleWrapper.find('h3');
                var titleH5 = titleWrapper.find('h5');
              Severity: Minor
              Found in app/assets/javascripts/analysis.js - About 4 hrs to fix

                Class Client has 32 methods (exceeds 20 allowed). Consider refactoring.
                Open

                  class Client
                    class ApiFailure < StandardError; end
                    class BadRequest < StandardError; end
                    class NotFound < StandardError; end
                    class NotAllowed < StandardError; end
                Severity: Minor
                Found in lib/transifex/client.rb - About 4 hrs to fix

                  Class HomeController has 31 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  class HomeController < ApplicationController
                    include VideoHelper
                    include ApplicationHelper
                  
                    # **** ALL ACTIONS IN THIS CONTROLLER ARE PUBLIC! ****
                  Severity: Minor
                  Found in app/controllers/home_controller.rb - About 3 hrs to fix

                    Method invalid_row_check has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def invalid_row_check
                        @reading_data.each_with_index do |reading, index|
                          reading_date = reading[:reading_date]
                          readings = reading[:readings]
                    
                    
                    Severity: Minor
                    Found in app/models/amr_reading_data.rb - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method charge_types has 88 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      def self.charge_types
                        {
                          standing_charge: {
                            units: [:day, :month, :quarter],
                            name: I18n.t('user_tariff_charge.standing_charge')
                    Severity: Major
                    Found in app/models/energy_tariff_charge.rb - About 3 hrs to fix

                      Method csv_report has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
                      Open

                            def csv_report(engaged_schools)
                              CSV.generate(headers: true) do |csv|
                                csv << ['School Group', 'School', 'Funder', 'Country', 'Activities', 'Actions',
                                        'Programmes', 'Target?', 'Transport survey?', 'Temperatures?', 'Audit?',
                                        'Active users', 'Last visit']
                      Severity: Minor
                      Found in app/controllers/admin/reports/engaged_schools_controller.rb - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Class AdviceBaseController has 28 methods (exceeds 20 allowed). Consider refactoring.
                      Open

                          class AdviceBaseController < ApplicationController
                            include NonPublicSchools
                            include AdvicePageHelper
                            include SchoolAggregation
                            include DashboardAlerts
                      Severity: Minor
                      Found in app/controllers/schools/advice/advice_base_controller.rb - About 3 hrs to fix

                        Class MeterCostsTableComponent has 28 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        class MeterCostsTableComponent < ViewComponent::Base
                          # Monthly costs: a hash of Date (first day of month) => Costs::MeterMonth
                          # Change in costs: a hash of Date (first day of month) => change in total cost for month (£)
                          # id: HTML id of the table
                          # year_header: display year header row in table
                        Severity: Minor
                        Found in app/components/meter_costs_table_component.rb - About 3 hrs to fix

                          Method initialize has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                          Open

                            def initialize(user)
                              user ||= User.new # guest user (not logged in)
                              alias_action :create, :read, :update, :destroy, to: :crud
                          
                              # all users can do these things
                          Severity: Minor
                          Found in app/models/ability.rb - About 3 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function carbon has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                          Open

                          export const carbon = ( function() {
                          
                            var local = {
                              neutral: '',
                              equivalences: '',
                          Severity: Minor
                          Found in app/javascript/packs/transport_surveys/carbon.js - About 3 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Class LandingPagesController has 25 methods (exceeds 20 allowed). Consider refactoring.
                          Open

                          class LandingPagesController < ApplicationController
                            TRUST = 'multi_academy_trust'.freeze
                            LA = 'local_authority'.freeze
                            # Needs to be aligned with values in set_org_types
                            GROUP_TYPES = [TRUST, LA].freeze
                          Severity: Minor
                          Found in app/controllers/landing_pages_controller.rb - About 2 hrs to fix

                            Class BaseController has 24 methods (exceeds 20 allowed). Consider refactoring.
                            Open

                              class BaseController < ApplicationController
                                include UserTypeSpecific
                                skip_before_action :authenticate_user!
                            
                                before_action :filter
                            Severity: Minor
                            Found in app/controllers/comparisons/base_controller.rb - About 2 hrs to fix

                              Function exports has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                              module.exports = function(api) {
                                var validEnv = ['development', 'test', 'production']
                                var currentEnv = api.env()
                                var isDevelopmentEnv = api.env('development')
                                var isProductionEnv = api.env('production')
                              Severity: Major
                              Found in babel.config.js - About 2 hrs to fix

                                Function chartSuccess has 64 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                function chartSuccess(chartConfig, chartData, chart) {
                                
                                  var $chartDiv = $(chart.renderTo);
                                  var chartType = chartData.chart1_type;
                                  var seriesData = chartData.series_data;
                                Severity: Major
                                Found in app/assets/javascripts/analysis.js - About 2 hrs to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language