Showing 166 of 304 total issues
Class School
has 79 methods (exceeds 20 allowed). Consider refactoring. Open
class School < ApplicationRecord
extend FriendlyId
include EnergyTariffHolder
include ParentMeterAttributeHolder
Class ChartDataValues
has 51 methods (exceeds 20 allowed). Consider refactoring. Open
class ChartDataValues
attr_reader :anaylsis_type, :title, :subtitle, :chart1_type, :chart1_subtype,
:y_axis_label, :x_axis_label, :x_axis_categories, :x_max_value, :x_min_value,
:advice_header, :advice_footer, :y2_axis_label, :y2_point_format, :y2_max, :x_axis_ranges, :annotations,
:transformations, :allowed_operations, :drilldown_available, :parent_timescale_description,
File school.rb
has 456 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'securerandom'
class School < ApplicationRecord
extend FriendlyId
include EnergyTariffHolder
File application_helper.rb
has 430 lines of code (exceeds 250 allowed). Consider refactoring. Open
module ApplicationHelper
include Pagy::Frontend
def nice_date_times(datetime, options = {})
return '' if datetime.nil?
Method initialize
has 151 lines of code (exceeds 25 allowed). Consider refactoring. Open
def initialize(user)
user ||= User.new # guest user (not logged in)
alias_action :create, :read, :update, :destroy, to: :crud
# all users can do these things
Function commonChartOptions
has 119 lines of code (exceeds 25 allowed). Consider refactoring. Open
function commonChartOptions(clickListener){
return {
colors: ["#9c3367", "#67347f", "#935fb8", "#e676a3", "#e4558b", "#7a9fb1", "#5297c6", "#97c086", "#3f7d69", "#6dc691", "#8e8d6b", "#e5c07c", "#e9d889", "#e59757", "#f4966c", "#e5644e", "#cd4851", "#bd4d65", "#515749"],
title: { text: null },
exporting: {
Class BaseloadService
has 35 methods (exceeds 20 allowed). Consider refactoring. Open
class BaseloadService < BaseService
include AnalysableMixin
def enough_data?
baseload_service.enough_data?
File common_chart_options.js
has 337 lines of code (exceeds 250 allowed). Consider refactoring. Open
Highcharts.setOptions({
lang: {
numericSymbols: null, //otherwise by default ['k', 'M', 'G', 'T', 'P', 'E']
thousandsSep: ','
},
File analysis.js
has 337 lines of code (exceeds 250 allowed). Consider refactoring. Open
"use strict";
function updateDynamicTitles(titleWrapper, chartData) {
var titleH3 = titleWrapper.find('h3');
var titleH5 = titleWrapper.find('h5');
Class Client
has 32 methods (exceeds 20 allowed). Consider refactoring. Open
class Client
class ApiFailure < StandardError; end
class BadRequest < StandardError; end
class NotFound < StandardError; end
class NotAllowed < StandardError; end
Class HomeController
has 31 methods (exceeds 20 allowed). Consider refactoring. Open
class HomeController < ApplicationController
include VideoHelper
include ApplicationHelper
# **** ALL ACTIONS IN THIS CONTROLLER ARE PUBLIC! ****
Method invalid_row_check
has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
def invalid_row_check
@reading_data.each_with_index do |reading, index|
reading_date = reading[:reading_date]
readings = reading[:readings]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function barColumnLine
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
function barColumnLine(chartData, highchartsChart, seriesData, chartConfig) {
var subChartType = chartData.chart1_subtype;
var chartType = chartData.chart1_type;
//console.log(chartType + ': ' + subChartType);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method charge_types
has 88 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.charge_types
{
standing_charge: {
units: [:day, :month, :quarter],
name: I18n.t('user_tariff_charge.standing_charge')
Method csv_report
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
def csv_report(engaged_schools)
CSV.generate(headers: true) do |csv|
csv << ['School Group', 'School', 'Funder', 'Country', 'Activities', 'Actions',
'Programmes', 'Target?', 'Transport survey?', 'Temperatures?', 'Audit?',
'Active users', 'Last visit']
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Class MeterCostsTableComponent
has 28 methods (exceeds 20 allowed). Consider refactoring. Open
class MeterCostsTableComponent < ViewComponent::Base
# Monthly costs: a hash of Date (first day of month) => Costs::MeterMonth
# Change in costs: a hash of Date (first day of month) => change in total cost for month (£)
# id: HTML id of the table
# year_header: display year header row in table
Class AdviceBaseController
has 28 methods (exceeds 20 allowed). Consider refactoring. Open
class AdviceBaseController < ApplicationController
include NonPublicSchools
include AdvicePageHelper
include SchoolAggregation
include DashboardAlerts
Method initialize
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
def initialize(user)
user ||= User.new # guest user (not logged in)
alias_action :create, :read, :update, :destroy, to: :crud
# all users can do these things
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function carbon
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
export const carbon = ( function() {
var local = {
neutral: '',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function setupLiveDataChart
has 78 lines of code (exceeds 25 allowed). Consider refactoring. Open
function setupLiveDataChart(container, maxVal) {
var chart = Highcharts.chart(container, {
chart: {
type: 'solidgauge',