Sign upLogin

BathHacked/energy-sparks

View on GitHub
Star
lib/data_feeds/geo_api.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method historic_month has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def historic_month(system_id, from_month, from_year, to_month, to_year)
Severity: Minor
Found in lib/data_feeds/geo_api.rb - About 35 mins to fix

    Method handle_response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def handle_response(response)
      raise NotAuthorised, error_message(response) if response.status == 401
      raise NotAllowed, error_message(response) if response.status == 403
      raise NotFound, error_message(response) if response.status == 404
      raise ApiFailure, error_message(response) unless response.success?
    Severity: Minor
    Found in lib/data_feeds/geo_api.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status