BathHacked/energy-sparks

View on GitHub
lib/transifex/client.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class Client has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Client
    class ApiFailure < StandardError; end
    class BadRequest < StandardError; end
    class NotFound < StandardError; end
    class NotAllowed < StandardError; end
Severity: Minor
Found in lib/transifex/client.rb - About 4 hrs to fix

    Method resource_data has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def resource_data(name, slug, project_id, categories, priority)
          {
            "data": {
              "attributes": {
                "accept_translations": true,
    Severity: Minor
    Found in lib/transifex/client.rb - About 1 hr to fix

      Method resource_data has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def resource_data(name, slug, project_id, categories, priority)
      Severity: Minor
      Found in lib/transifex/client.rb - About 35 mins to fix

        Method check_response_status has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def check_response_status(response)
              raise BadRequest.new(error_message(response)) if response.status == 400
              raise NotAuthorised.new(error_message(response)) if response.status == 401
              raise NotAllowed.new(error_message(response)) if response.status == 403
              raise NotFound.new(error_message(response)) if response.status == 404
        Severity: Minor
        Found in lib/transifex/client.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status