Sign upLogin

Battle-Cattle/BCUK-Bot-3

View on GitHub
Star

Showing 130 of 140 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public Punishment newPunishment()
    {
        List<Punishment> punishmentsAvailable = punishments.findByPunishmentGiven(false);
        int size = punishmentsAvailable.size();
        cPunishment = null;
Severity: Major
Found in src/main/java/com/expiredminotaur/bcukbot/fun/tasks/TaskManager.java and 1 other location - About 1 hr to fix
src/main/java/com/expiredminotaur/bcukbot/fun/tasks/TaskManager.java on lines 63..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static Profile getProfile(String UUID)
    {
        try(BufferedReader br = HttpHandler.webRequest(new URL("https://sessionserver.mojang.com/session/minecraft/profile/" + UUID)))
        {
            String output = br.lines().collect(Collectors.joining());
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/mojang/UuidApi.java and 1 other location - About 50 mins to fix
src/main/java/com/expiredminotaur/bcukbot/mojang/UuidApi.java on lines 15..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static NameWithUUID nameToUUID(String name)
    {
        try(BufferedReader br = HttpHandler.webRequest(new URL("https://api.mojang.com/users/profiles/minecraft/" + name)))
        {
            String output = br.lines().collect(Collectors.joining());
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/mojang/UuidApi.java and 1 other location - About 50 mins to fix
src/main/java/com/expiredminotaur/bcukbot/mojang/UuidApi.java on lines 27..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public void update(Group group, Stream newStream)
    {
        if (stream == null)
        {
            stream = newStream;
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/twitch/streams/StreamData.java - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package com.expiredminotaur.bcukbot.rest;

public class SfxRequest
{
    String sfx;
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/rest/SfxRequest.java and 1 other location - About 40 mins to fix
src/main/java/com/expiredminotaur/bcukbot/rest/JoinRequest.java on lines 1..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package com.expiredminotaur.bcukbot.rest;

public class JoinRequest
{
    Long channelId;
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/rest/JoinRequest.java and 1 other location - About 40 mins to fix
src/main/java/com/expiredminotaur/bcukbot/rest/SfxRequest.java on lines 1..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        try (FileReader fr = new FileReader(JustGivingSettings.getFileName()))
        {
            settings = gson.fromJson(fr, JustGivingSettings.class);
        } catch (IOException e)
        {
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/justgiving/JustGivingAPI.java and 1 other location - About 40 mins to fix
src/main/java/com/expiredminotaur/bcukbot/json/Settings.java on lines 22..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        try (FileReader fr = new FileReader(SettingsJson.getFileName()))
        {
            settings = gson.fromJson(fr, SettingsJson.class);
        } catch (IOException e)
        {
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/json/Settings.java and 1 other location - About 40 mins to fix
src/main/java/com/expiredminotaur/bcukbot/justgiving/JustGivingAPI.java on lines 58..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method correctAnswerPost has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private void correctAnswerPost(MessageChannel channel, Questions.Question question, ReactionEmoji.Unicode emoji, String answer, List<User> correct)
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/fun/trivia/TriviaGame.java - About 35 mins to fix

Method update has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private void update(Message message, EmbedCreateSpec embed, Outcome outcome, String[] display, int i)
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/fun/slot/SlotGame.java - About 35 mins to fix

Method addMinecraftWhitelist has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private String addMinecraftWhitelist(Long discordID, String username)
    {
        NameWithUUID newUser = UuidApi.nameToUUID(username);
        if (newUser != null)
        {
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/discord/command/MinecraftCommands.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method checkBannedPhrases has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean checkBannedPhrases(TwitchCommandEvent event)
    {
        if (TwitchPermissions.subPlus(event))
            return false;
        else
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/twitch/BanHandler.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private void sendMessageToDiscord()
    {
        if (totalRaisedMessage != null && settings.getDiscordChannelIds() != null)
        {
            for (long channel : settings.getDiscordChannelIds())
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/justgiving/JustGivingAPI.java and 1 other location - About 35 mins to fix
src/main/java/com/expiredminotaur/bcukbot/justgiving/JustGivingAPI.java on lines 150..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private void sendMessageToAll()
    {
        if (totalRaisedMessage != null && settings.getChannels() != null)
        {
            for (String channel : settings.getChannels())
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/justgiving/JustGivingAPI.java and 1 other location - About 35 mins to fix
src/main/java/com/expiredminotaur/bcukbot/justgiving/JustGivingAPI.java on lines 159..166

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private void selectTask()
    {
        Task task = taskManager.newTask();
        if (task != null)
        {
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/web/view/admin/StreamBroadcasterView.java and 1 other location - About 30 mins to fix
src/main/java/com/expiredminotaur/bcukbot/web/view/admin/StreamBroadcasterView.java on lines 82..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private void selectPunishment()
    {
        Punishment punishment = taskManager.newPunishment();
        if (punishment != null)
        {
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/web/view/admin/StreamBroadcasterView.java and 1 other location - About 30 mins to fix
src/main/java/com/expiredminotaur/bcukbot/web/view/admin/StreamBroadcasterView.java on lines 57..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method play has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public void play(String cmd)
    {
        long time = System.currentTimeMillis();
        if (time - lastSFX > settings.getSfxDelay() * 1000L)
        {
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/discord/music/SFXHandler.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method onChannelMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private void onChannelMessage(ChannelMessageEvent event)
    {
        TwitchCommandEvent cEvent = new TwitchCommandEvent(event);
        if (!banHandler.checkBannedPhrases(cEvent))
        {
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/twitch/TwitchBot.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

First sentence of Javadoc is missing an ending period.
Open

/**
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/command/Command.java by checkstyle

Checks thatJavadoc summary sentence does not contain phrases that are not recommended to use.Summaries that contain only the {@inheritDoc} tag are skipped. Check alsoviolate Javadoc that does not contain first sentence.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Unicode escape(s) usage should be avoided.
Open

    public static final ReactionEmoji.Unicode A = ReactionEmoji.unicode("\uD83C\uDDE6");
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/discord/Emoji.java by checkstyle

Restricts usingUnicode escapes (such as \u221e).It is possible to allow using escapes fornon-printable, control characters.Also, this check can be configured to allow using escapesif trail comment is present. By the option it is possible toallow using escapes if literal contains only them.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Severity
Category
Status
Source
Language