Battle-Cattle/BCUK-Bot-3

View on GitHub

Showing 130 of 140 total issues

Unicode escape(s) usage should be avoided.
Open

    public static final ReactionEmoji.Unicode C = ReactionEmoji.unicode("\uD83C\uDDE8");

Restricts usingUnicode escapes (such as \u221e).It is possible to allow using escapes fornon-printable, control characters.Also, this check can be configured to allow using escapesif trail comment is present. By the option it is possible toallow using escapes if literal contains only them.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Unicode escape(s) usage should be avoided.
Open

    public static final ReactionEmoji.Unicode FALSE = ReactionEmoji.unicode("\uD83D\uDEAB");

Restricts usingUnicode escapes (such as \u221e).It is possible to allow using escapes fornon-printable, control characters.Also, this check can be configured to allow using escapesif trail comment is present. By the option it is possible toallow using escapes if literal contains only them.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Parameter name 'UUID' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
Open

    public static Profile getProfile(String UUID)

Checks that method parameter names conform to a specified pattern.By using accessModifiers property it is possibleto specify different formats for methods at different visibility levels.

To validate catch parameters please useCatchParameterName.

To validate lambda parameters please useLambdaParameterName.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Parameter name 'ClipId' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
Open

    void deleteById(@NotNull Integer ClipId);

Checks that method parameter names conform to a specified pattern.By using accessModifiers property it is possibleto specify different formats for methods at different visibility levels.

To validate catch parameters please useCatchParameterName.

To validate lambda parameters please useLambdaParameterName.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Parameter name 'Joke' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
Open

    void delete(@NotNull Joke Joke);

Checks that method parameter names conform to a specified pattern.By using accessModifiers property it is possibleto specify different formats for methods at different visibility levels.

To validate catch parameters please useCatchParameterName.

To validate lambda parameters please useLambdaParameterName.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Parameter name 'CounterId' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
Open

    void deleteById(@NotNull Integer CounterId);

Checks that method parameter names conform to a specified pattern.By using accessModifiers property it is possibleto specify different formats for methods at different visibility levels.

To validate catch parameters please useCatchParameterName.

To validate lambda parameters please useLambdaParameterName.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Parameter name 'Counter' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
Open

    void delete(@NotNull Counter Counter);

Checks that method parameter names conform to a specified pattern.By using accessModifiers property it is possibleto specify different formats for methods at different visibility levels.

To validate catch parameters please useCatchParameterName.

To validate lambda parameters please useLambdaParameterName.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Parameter name 'GroupId' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
Open

    void deleteById(@NotNull Integer GroupId);

Checks that method parameter names conform to a specified pattern.By using accessModifiers property it is possibleto specify different formats for methods at different visibility levels.

To validate catch parameters please useCatchParameterName.

To validate lambda parameters please useLambdaParameterName.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Member name 'cTask' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
Open

    private Task cTask = null;

Unicode escape(s) usage should be avoided.
Open

    private static final String[] emojis = {"\uD83C\uDF47", "\uD83C\uDF4A", "\uD83C\uDF52", "\uD83C\uDF53"};

Restricts usingUnicode escapes (such as \u221e).It is possible to allow using escapes fornon-printable, control characters.Also, this check can be configured to allow using escapesif trail comment is present. By the option it is possible toallow using escapes if literal contains only them.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'+' should be on a new line.
Open

                "&client_secret=" + URLEncoder.encode(System.getenv("BCUK_BOT_TWITCH_CLIENT_SECRET"), StandardCharsets.UTF_8) +

Distance between variable 'multiTwitch' declaration and its first usage is 13, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
Open

            Checkbox multiTwitch = new Checkbox("Post MultiTwitch Links");

Checks the distance between declaration of variable and its first usage.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'+' should be on a new line.
Open

            Text message = new Text("Are you sure you want to delete " + streamer.getName() +

Distance between variable 'binder' declaration and its first usage is 6, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
Open

        Binder<JustGivingSettings> binder = new Binder<>(JustGivingSettings.class);

Checks the distance between declaration of variable and its first usage.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Parameter name 'Quote' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
Open

    @NotNull <S extends Quote> S save(@NotNull S Quote);

Checks that method parameter names conform to a specified pattern.By using accessModifiers property it is possibleto specify different formats for methods at different visibility levels.

To validate catch parameters please useCatchParameterName.

To validate lambda parameters please useLambdaParameterName.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'+' should be on a new line.
Open

                Emoji.B.getRaw() + parseText(answers.get(1)) + "\n" +

Unicode escape(s) usage should be avoided.
Open

    private static final String[] emojis = {"\uD83C\uDF47", "\uD83C\uDF4A", "\uD83C\uDF52", "\uD83C\uDF53"};

Restricts usingUnicode escapes (such as \u221e).It is possible to allow using escapes fornon-printable, control characters.Also, this check can be configured to allow using escapesif trail comment is present. By the option it is possible toallow using escapes if literal contains only them.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'protected' modifier out of order with the JLS suggestions.
Open

    abstract protected void saveData(T data);

Checks that the order of modifiers conforms to the suggestions inthe JavaLanguage specification, § 8.1.1, 8.3.1, 8.4.3 and9.4. The correct order is:

  1. public
  2. protected
  3. private
  4. abstract
  5. default
  6. static
  7. final
  8. transient
  9. volatile
  10. synchronized
  11. native
  12. strictfp

In additional, modifiers are checked to ensure all annotations aredeclared before all other modifiers.

Rationale: Code is easier to read if everybody follows a standard.

ATTENTION: We skiptype annotations from validation.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Parameter name 'Streamer' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
Open

    @NotNull <S extends Streamer> S save(@NotNull S Streamer);

Checks that method parameter names conform to a specified pattern.By using accessModifiers property it is possibleto specify different formats for methods at different visibility levels.

To validate catch parameters please useCatchParameterName.

To validate lambda parameters please useLambdaParameterName.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Severity
Category
Status
Source
Language