Sign upLogin

Bernd-L/exDateMan

View on GitHub
Star

Showing 114 of 114 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    categoryData?: {
      /**
       * The name of the category
       */
      name?: string;
Severity: Minor
Found in frontend/src/app/services/EventSourcing/event-sourcing.service.ts and 1 other location - About 30 mins to fix
backend/src/app/client-events.ts on lines 342..361

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    categoryData?: {
      /**
       * The name of the category
       */
      name?: string;
Severity: Minor
Found in backend/src/app/client-events.ts and 1 other location - About 30 mins to fix
frontend/src/app/services/EventSourcing/event-sourcing.service.ts on lines 340..359

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function fetchInventoryEvents has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  private async fetchInventoryEvents() {
    // Initialize the inventory projection dictionary
    InventoryService.inventoriesProjection = {};

    // Wait for EventSourcingService to be ready
Severity: Minor
Found in frontend/src/app/services/inventory/inventory.service.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

      // TODO remove log
Severity: Minor
Found in frontend/src/app/guards/login.guard.ts by fixme

TODO found
Open

  // TODO redo
Severity: Minor
Found in frontend/src/app/services/auth/auth.service.ts by fixme

TODO found
Open

    // TODO implement access rights #91
Severity: Minor
Found in frontend/src/app/services/inventory/inventory.service.ts by fixme

TODO found
Open

    // TODO revisit; maybe remove `if`
Severity: Minor
Found in frontend/src/app/components/edit-inventory/edit-inventory.component.ts by fixme

TODO found
Open

    // TODO remove log
Severity: Minor
Found in frontend/src/app/components/inventories/inventories.component.ts by fixme

TODO found
Open

      this.user = ((await this.as.getCurrentUser()).user as unknown) as User; // TODO FixMe
Severity: Minor
Found in frontend/src/app/components/account/account.component.ts by fixme

TODO found
Open

    // TODO implement
Severity: Minor
Found in frontend/src/app/components/edit-inventory/edit-inventory.component.ts by fixme

TODO found
Open

  // TODO add support for shared inventories
Severity: Minor
Found in frontend/src/app/components/add-inventory/add-inventory.component.ts by fixme

TODO found
Open

   * // TODO revisit
Severity: Minor
Found in frontend/src/app/components/edit-inventory/edit-inventory.component.ts by fixme

TODO found
Open

    // throw new Error("Method not implemented."); // TODO implement inventories projection
Severity: Minor
Found in frontend/src/app/services/inventory/inventory.service.ts by fixme

TODO found
Open

      console.log("oof"); // TODO remove log
Severity: Minor
Found in frontend/src/app/components/add-thing/add-thing.component.ts by fixme
Severity
Category
Status
Source
Language