BookStackApp/BookStack

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        this.elem.addEventListener('click', event => {
            if (event.target.closest('[data-sort-dir]') !== null) {
                this.sortDirectionClick(event);
            }
        });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        this.menu.addEventListener('click', event => {
            if (event.target.closest('[data-sort-value]') !== null) {
                this.sortOptionClick(event);
            }
        });

• Read up
  Read up

Method validateTokenClaims has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function validateTokenClaims(string $clientId): void
    {
        // 1. The Issuer Identifier for the OpenID Provider (which is typically obtained during Discovery)
        // MUST exactly match the value of the iss (issuer) Claim.
        // Already done in parent.

Function setup has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    setup() {
        // Options
        this.uploadedTo = this.$opts.uploadedTo;

        // Element References

Function paste has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function paste(editor, options, event) {
    const clipboard = new Clipboard(event.clipboardData || event.dataTransfer);

    // Don't handle the event ourselves if no items exist of contains table-looking data
    if (!clipboard.hasItems() || clipboard.containsTabularData()) {

Method createManyJointPermissions has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function createManyJointPermissions(array $originalEntities, array $roles)
    {
        $entities = $this->entitiesToSimpleEntities($originalEntities);
        $jointPermissions = [];

Function createDomForFile has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    createDomForFile(file) {
        const image = elem('img', {src: "data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24'%3E%3Cpath d='M9.224 7.373a.924.924 0 0 0-.92.925l-.006 7.404c0 .509.412.925.921.925h5.557a.928.928 0 0 0 .926-.925v-5.553l-2.777-2.776Zm3.239 3.239V8.067l2.545 2.545z' style='fill:%23000;fill-opacity:.75'/%3E%3C/svg%3E"});
        const status = elem('div', {class: 'dropzone-file-item-status'}, []);
        const progress = elem('div', {class: 'dropzone-file-item-progress'});
        const imageWrap = elem('div', {class: 'dropzone-file-item-image-wrap'}, [image]);

Function parsePlural has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    parsePlural(translation, count, replacements) {
        const splitText = translation.split('|');
        const exactCountRegex = /^{([0-9]+)}/;
        const rangeRegex = /^\[([0-9]+),([0-9*]+)]/;
        let result = null;

Method attempt has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function attempt(array $credentials = [], $remember = false)
    {
        $username = $credentials['username'];
        $userDetails = $this->ldapService->getUserDetails($username);

Function setupListeners has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    setupListeners() {
        const navHandler = new KeyboardNavigationHandler(
            this.list,
            () => {
                this.input.focus();

Method show has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function show(Request $request, ActivityQueries $activities, string $slug)
    {
        $shelf = $this->queries->findVisibleBySlugOrFail($slug);
        $this->checkOwnablePermission('bookshelf-view', $shelf);

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public function showDelete(string $bookSlug, string $chapterSlug)
    {
        $chapter = $this->queries->findVisibleBySlugsOrFail($bookSlug, $chapterSlug);
        $this->checkOwnablePermission('chapter-delete', $chapter);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public function edit(string $bookSlug, string $chapterSlug)
    {
        $chapter = $this->queries->findVisibleBySlugsOrFail($bookSlug, $chapterSlug);
        $this->checkOwnablePermission('chapter-update', $chapter);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    created(a, b) {
        const aTime = Number(a.getAttribute('data-created'));
        const bTime = Number(b.getAttribute('data-created'));
        return bTime - aTime;
    },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    open() {
        this.container.classList.add('open');
        this.trigger.setAttribute('aria-expanded', 'true');
        slideDown(this.content, 300);
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    close() {
        this.container.classList.remove('open');
        this.trigger.setAttribute('aria-expanded', 'false');
        slideUp(this.content, 300);
    }

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

        if ($model instanceof Chapter) {
            $hasPermission = userCan('book-update', $currentParent)
                && userCan('book-update', $newBook)
                && userCan('chapter-update', $model)
                && (!$hasNewParent || userCan('chapter-create', $newBook))

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    updated(a, b) {
        const aTime = Number(a.getAttribute('data-updated'));
        const bTime = Number(b.getAttribute('data-updated'));
        return bTime - aTime;
    },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        for (const toggleAllElem of (this.$manyRefs.toggleAll || [])) {
            toggleAllElem.addEventListener('click', this.toggleAllClick.bind(this));
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        for (const toggleRowElem of (this.$manyRefs.toggleRow || [])) {
            toggleRowElem.addEventListener('click', this.toggleRowClick.bind(this));
        }

• Read up
  Read up