Sign upLogin

Boostport/migration

View on GitHub
Star
driver/mysql/mysql.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function New has 5 return statements (exceeds 4 allowed).
Open

func New(dsn string) (m.Driver, error) {
    parsedDSN, err := mysql.ParseDSN(dsn)
    if err != nil {
        return nil, err
    }
Severity: Major
Found in driver/mysql/mysql.go - About 35 mins to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    func (driver *Driver) Versions() ([]string, error) {
    var versions []string

    rows, err := driver.db.Query("SELECT version FROM " + mysqlTableName + " ORDER BY version DESC")
    if err != nil {
    Severity: Major
    Found in driver/mysql/mysql.go and 3 other locations - About 1 hr to fix
    driver/phoenix/phoenix.go on lines 113..136
    driver/postgres/postgres.go on lines 125..148
    driver/sqlite/sqlite.go on lines 135..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 184.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    func NewFromDB(db *sql.DB) (m.Driver, error) {
    if _, ok := db.Driver().(*mysql.MySQLDriver); !ok {
        return nil, errors.New("database instance is not using the MySQL driver")
    }
    Severity: Major
    Found in driver/mysql/mysql.go and 3 other locations - About 1 hr to fix
    driver/phoenix/phoenix.go on lines 43..61
    driver/postgres/postgres.go on lines 42..58
    driver/sqlite/sqlite.go on lines 48..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 153.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if migration.Direction == m.Up {
        if _, err := driver.db.Exec("INSERT INTO "+mysqlTableName+" (version) VALUES (?)", migration.ID); err != nil {
            return err
        }
    } else {
    Severity: Minor
    Found in driver/mysql/mysql.go and 1 other location - About 40 mins to fix
    driver/phoenix/phoenix.go on lines 99..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status