CDJ11/CDJ

File graphql_spec.rb has 517 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'rails_helper'

api_types  = GraphQL::ApiTypesCreator.create(API_TYPE_DEFINITIONS)
query_type = GraphQL::QueryTypeCreator.create(api_types)
ConsulSchema = GraphQL::Schema.define do

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it 'only retruns tags with kind nil or category' do
      tag          = create(:tag, name: 'Parks')
      category_tag = create(:tag, :category, name: 'Health')
      admin_tag    = create(:tag, name: 'Admin tag', kind: 'admin')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it 'only retruns tags with kind nil or category' do
      tag          = create(:tag, name: 'Parks')
      category_tag = create(:tag, :category, name: 'Health')
      admin_tag    = create(:tag, name: 'Admin tag', kind: 'admin')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it 'does not include votes of comments from a hidden proposal' do
      visible_proposal = create(:proposal)
      hidden_proposal  = create(:proposal, :hidden)

      visible_proposal_comment = create(:comment, commentable: visible_proposal)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it 'does not include votes of comments from a hidden debate' do
      visible_debate = create(:debate)
      hidden_debate  = create(:debate, :hidden)

      visible_debate_comment = create(:comment, commentable: visible_debate)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'displays comments of authors even if public activity is set to false' do
      visible_author = create(:user, public_activity: true)
      hidden_author  = create(:user, public_activity: false)

      visible_comment = create(:comment, user: visible_author)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'includes debates of authors even if public activity is set to false' do
      visible_author = create(:user, public_activity: true)
      hidden_author  = create(:user, public_activity: false)

      visible_debate = create(:debate, author: visible_author)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'includes proposals of authors even if public activity is set to false' do
      visible_author = create(:user, public_activity: true)
      hidden_author  = create(:user, public_activity: false)

      visible_proposal = create(:proposal, author: visible_author)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not link author if public activity is set to false' do
      visible_author = create(:user, public_activity: true)
      hidden_author  = create(:user, public_activity: false)

      visible_comment = create(:comment, author: visible_author)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not link author if public activity is set to false' do
      visible_author = create(:user, public_activity: true)
      hidden_author  = create(:user, public_activity: false)

      visible_proposal = create(:proposal, author: visible_author)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not link author if public activity is set to false' do
      visible_author = create(:user, public_activity: true)
      hidden_author  = create(:user, public_activity: false)

      visible_debate = create(:debate, author: visible_author)

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it 'does not include votes of hidden comments' do
      visible_comment = create(:comment)
      hidden_comment  = create(:comment, hidden_at: Time.current)

      visible_comment_vote = create(:vote, votable: visible_comment)

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it 'does not include comments from hidden debates' do
      visible_debate = create(:debate)
      hidden_debate  = create(:debate, hidden_at: Time.current)

      visible_debate_comment = create(:comment, commentable: visible_debate)

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it 'does not include comments from hidden polls' do
      visible_poll = create(:poll)
      hidden_poll  = create(:poll, hidden_at: Time.current)

      visible_poll_comment = create(:comment, commentable: visible_poll)

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it 'does not include votes of hidden proposals' do
      visible_proposal = create(:proposal)
      hidden_proposal  = create(:proposal, hidden_at: Time.current)

      visible_proposal_vote = create(:vote, votable: visible_proposal)

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it 'does not include comments from hidden proposals' do
      visible_proposal = create(:proposal)
      hidden_proposal  = create(:proposal, hidden_at: Time.current)

      visible_proposal_comment = create(:comment, commentable: visible_proposal)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it 'uppercase and lowercase tags work ok together for proposals' do
      create(:tag, name: 'Health')
      create(:tag, name: 'health')
      create(:proposal, tag_list: 'health')
      create(:proposal, tag_list: 'Health')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it 'uppercase and lowercase tags work ok together for debates' do
      create(:tag, name: 'Health')
      create(:tag, name: 'health')
      create(:debate, tag_list: 'Health')
      create(:debate, tag_list: 'health')

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'only links proposal if public' do
      visible_proposal = create(:proposal)
      hidden_proposal  = create(:proposal, :hidden)

      visible_proposal_notification = create(:proposal_notification, proposal: visible_proposal)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not include votes from hidden debates' do
      visible_debate = create(:debate)
      hidden_debate  = create(:debate, :hidden)

      visible_debate_vote = create(:vote, votable: visible_debate)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not include proposal notifications for hidden proposals' do
      visible_proposal = create(:proposal)
      hidden_proposal  = create(:proposal, :hidden)

      visible_proposal_notification = create(:proposal_notification, proposal: visible_proposal)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not include comments of proposals that are not public' do
      not_public_proposal = create(:proposal)
      not_public_proposal_comment = create(:comment, commentable: not_public_proposal)
      allow(Comment).to receive(:public_for_api).and_return([])

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not include proposal notifications for proposals that are not public' do
      not_public_proposal = create(:proposal)
      not_public_proposal_notification = create(:proposal_notification, proposal: not_public_proposal)
      allow(ProposalNotification).to receive(:public_for_api).and_return([])

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not include votes of debates that are not public' do
      not_public_debate = create(:debate)
      allow(Vote).to receive(:public_for_api).and_return([])

      not_public_debate_vote = create(:vote, votable: not_public_debate)

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it 'only returns date and hour for created_at' do
      created_at = Time.zone.parse("2017-12-31 9:30:15")
      create(:comment, created_at: created_at)

      response = execute('{ comments { edges { node { public_created_at } } } }')

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not include votes of a hidden proposals' do
      not_public_proposal = create(:proposal)
      allow(Vote).to receive(:public_for_api).and_return([])

      not_public_proposal_vote = create(:vote, votable: not_public_proposal)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not include comments of polls that are not public' do
      not_public_poll = create(:poll)
      not_public_poll_comment = create(:comment, commentable: not_public_poll)
      allow(Comment).to receive(:public_for_api).and_return([])

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it 'only returns date and hour for created_at' do
      created_at = Time.zone.parse("2017-12-31 9:30:15")
      create(:debate, created_at: created_at)

      response = execute('{ debates { edges { node { public_created_at } } } }')

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not include votes of a hidden comments' do
      not_public_comment = create(:comment)
      allow(Vote).to receive(:public_for_api).and_return([])

      not_public_comment_vote = create(:vote, votable: not_public_comment)

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it 'only returns date and hour for created_at' do
      created_at = Time.zone.parse("2017-12-31 9:30:15")
      create(:proposal, created_at: created_at)

      response = execute('{ proposals { edges { node { public_created_at } } } }')

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it 'only returns date and hour for created_at' do
      created_at = Time.zone.parse("2017-12-31 9:30:15")
      create(:proposal_notification, created_at: created_at)

      response = execute('{ proposal_notifications { edges { node { public_created_at } } } }')

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it 'only returns date and hour for created_at' do
      created_at = Time.zone.parse("2017-12-31 9:30:15")
      create(:vote, created_at: created_at)

      response = execute('{ votes { edges { node { public_created_at } } } }')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it 'does not include hidden proposals' do
      visible_proposal = create(:proposal)
      hidden_proposal  = create(:proposal, :hidden)

      response = execute('{ proposals { edges { node { title } } } }')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it 'does not include hidden debates' do
      visible_debate = create(:debate)
      hidden_debate  = create(:debate, :hidden)

      response = execute('{ debates { edges { node { title } } } }')

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not link proposals if activity is not public' do
      create(:proposal, author: user)

      response = execute("{ user(id: #{user.id}) { public_proposals { edges { node { title } } } } }")
      received_proposals = dig(response, 'data.user.public_proposals.edges')

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not link debates if activity is not public' do
      create(:debate, author: user)

      response = execute("{ user(id: #{user.id}) { public_debates { edges { node { title } } } } }")
      received_debates = dig(response, 'data.user.public_debates.edges')

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it 'does not link comments if activity is not public' do
      create(:comment, author: user)

      response = execute("{ user(id: #{user.id}) { public_comments { edges { node { body } } } } }")
      received_comments = dig(response, 'data.user.public_comments.edges')

• Read up
  Read up

Line is too long. [115/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      response = execute("{ proposal(id: #{proposal.id}) { votes_for { edges { node { public_created_at } } } } }")

• Exclude checks
  • Disable engine
  • Disable check

The first argument to describe should be the class or module being tested. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribeClass)

Open

describe 'Consul Schema' do

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [104/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    expect(dig(response, 'data.proposal.public_author.username')).to eq(proposal.public_author.username)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [102/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      not_public_proposal_notification = create(:proposal_notification, proposal: not_public_proposal)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    response = execute("{ proposal(id: #{org_proposal.id}) { public_author { organization { name } } } }")

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [118/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      spending_proposal_comment = build(:comment, commentable: create(:spending_proposal)).save(skip_validation: true)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [138/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      valid_proceeding_proposal = create(:proposal, proceeding: 'Derechos Humanos', sub_proceeding: 'Right to a Home', tag_list: 'Health')

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [109/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    response = execute("{ proposals(first: 1) { edges { node { public_author { encrypted_password } } } } }")

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [129/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

  error_is_present = ((response['errors'].first['message'] =~ /Field '#{field_name}' doesn't exist on type '[[:alnum:]]*'/) == 0)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [102/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      response = execute("{ user(id: #{user.id}) { public_proposals { edges { node { title } } } } }")

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [118/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      human_rights_proposal = create(:proposal, proceeding: 'Derechos Humanos', sub_proceeding: 'Right to have a job')

• Exclude checks
  • Disable engine
  • Disable check