CMSgov/dpc-app

Identical blocks of code found in 3 locations. Consider refactoring.

Open

  config.lograge.custom_options = lambda do |event|
    { ddsource: 'ruby',
      params: event.payload[:params].reject { |k| %w(controller action).include? k },
      environment: ENV['ENV'] || :development,
      exception: event.payload[:exception],

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    @Inject
    public DataService(IJobQueue queue, FhirContext fhirContext, @ExportPath String exportPath, @JobTimeout int jobTimeoutInSeconds) {
        this.queue = queue;
        this.fhirContext = fhirContext;
        this.exportPath = exportPath;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Confirmed

    public ProviderEntity updateProvider(UUID providerID, ProviderEntity providerEntity) {
        final ProviderEntity existingProvider = this.getProvider(providerID)
                .orElseThrow(() -> new IllegalArgumentException("Cannot find provider"));

        final ProviderEntity fullyUpdated = existingProvider.update(providerEntity);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Confirmed

    public PatientEntity updatePatient(UUID patientID, PatientEntity updatedPatient) {
        final PatientEntity patient = this.getPatient(patientID)
                .orElseThrow(() -> new IllegalArgumentException("Cannot find patient"));

        final PatientEntity fullyUpdated = patient.update(updatedPatient);

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

  if (typeof ElementProto.matches !== 'function') {
    ElementProto.matches = ElementProto.msMatchesSelector || ElementProto.mozMatchesSelector || ElementProto.webkitMatchesSelector || function matches(selector) {
      var element = this;
      var elements = (element.document || element.ownerDocument).querySelectorAll(selector);
      var index = 0;

Function getAssumeRoleArn has 6 return statements (exceeds 4 allowed).

Open

func getAssumeRoleArn() (string, error) {
    if isTesting {
        val := os.Getenv("AWS_ASSUME_ROLE_ARN")
        if val == "" {
            return "", fmt.Errorf("AWS_ASSUME_ROLE_ARN must be set during testing")

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    public LookBackAnswer(String practitionerNPI, String organizationNPI, long withinMonths, YearMonth lookBackMonth) {
        this.practitionerNPI = practitionerNPI;
        this.organizationNPI = organizationNPI;
        this.withinMonths = withinMonths;
        this.lookBackMonth = lookBackMonth;

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    protected DPCAuthFilter(MacaroonBakery bakery, Authenticator<DPCAuthCredentials, OrganizationPrincipal> auth, TokenDAO dao, DPCUnauthorizedHandler dpc401handler ) {
        this.authenticator = auth;
        this.bakery = bakery;
        this.dao = dao;
        this.dpc401handler = dpc401handler;

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

package gov.cms.dpc.common.annotations;

import gov.cms.dpc.common.hibernate.validator.NPIValidator;

import javax.validation.Constraint;

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

package gov.cms.dpc.common.annotations;

import gov.cms.dpc.common.hibernate.validator.OrganizationIdValidator;

import javax.validation.Constraint;

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    public DPCAuthCredentials(String macaroon, Organization organization, PathAuthorizer pa, String pathValue) {
        this.macaroon = macaroon;
        this.organization = organization;
        this.pa = pa;
        this.pathValue = pathValue;

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

package gov.cms.dpc.common.annotations;

import gov.cms.dpc.common.hibernate.validator.NoHtmlValidator;

import javax.validation.Constraint;

• Read up
  Read up

Function UploadFileToS3 has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func UploadFileToS3(s *session.Session, fileName string, buff bytes.Buffer, s3Bucket string, s3Path string) error {

Method generate_credentials has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

def generate_credentials(credentials, org_bundle, public_key_label, path_to_org_pub_key, expiration)

Method createRosterSubmission has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    private static void createRosterSubmission(IGenericClient client, InputStream resource, Bundle providerBundle, UUID organizationID, Map<String, Reference> patientReferences) throws IOException {

Method retrieveData has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public Resource retrieveData(UUID organizationId, String orgNPI, String providerNPI, List<String> patientIds, DPCResourceType... resourceTypes) {

Method encodeSecretPart has 5 arguments (exceeds 4 allowed). Consider refactoring.

Confirmed

    static byte[] encodeSecretPart(byte[] thirdPartyKey, byte[] privateKey, byte[] nonce, String rootKey, String caveat) {

Method registerOrganization has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public static String registerOrganization(IGenericClient client, IParser parser, String organizationID, String organizationNPI, String adminURL) throws IOException {

Method fetchBundle has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    private <T extends IBaseResource> Bundle fetchBundle(Class<T> resourceClass,
                                                         List<ICriterion<? extends IParam>> criteria,
                                                         String patientID,
                                                         DateRangeParam lastUpdated,
                                                         Map<String, String> headers) {

Method exportDataAndHandleResults has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    private void exportDataAndHandleResults(IGenericClient exportClient, Bundle providerBundle, String clientToken, Pair<UUID,PrivateKey> keyTuple, SampleResult parentSampler){