CORE-POS/IS4C

View on GitHub

Showing 8,683 of 8,684 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

while($itemsW = $dbc->fetch_row($itemsR)){
    if (!isset($items[$itemsW['order_id']]))
        $items[$itemsW['order_id']] = $itemsW['description'];
    else
        $items[$itemsW['order_id']] .= "; ".$itemsW['description'];
Severity: Major
Found in fannie/ordering/clearinghouse.php and 1 other location - About 3 hrs to fix
fannie/ordering/historical.php on lines 272..285

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 151.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

static public function code128($barcode, $forcePaper=false)
{
    if (!is_object(self::$PRINT)) {
        self::$PRINT= PrintHandler::factory(CoreLocal::get('ReceiptDriver'));
    }
Severity: Major
Found in pos/is4c-nf/lib/ReceiptLib.php and 1 other location - About 3 hrs to fix
pos/is4c-nf/lib/ReceiptLib.php on lines 1145..1156

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 151.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

static public function code39($barcode, $forcePaper=false)
{
    if (!is_object(self::$PRINT)) {
        self::$PRINT= PrintHandler::factory(CoreLocal::get('ReceiptDriver'));
    }
Severity: Major
Found in pos/is4c-nf/lib/ReceiptLib.php and 1 other location - About 3 hrs to fix
pos/is4c-nf/lib/ReceiptLib.php on lines 1158..1169

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 151.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method handleResponseAuth has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function handleResponseAuth($authResult)
    {
        $resp = $this->desoapify("GiftTransactionResult",
            $authResult["response"]);
        $xml = new BetterXmlData($resp);
Severity: Major
Found in pos/is4c-nf/plugins/Paycards/MercuryGift.php - About 3 hrs to fix

    Method head_content has 86 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function head_content()
        {
            ?>
    <style type="text/css">
    /**
    Severity: Major
    Found in pos/is4c-nf/plugins/StripeDotCom/gui/StripeCreditPage.php - About 3 hrs to fix

      Method simpleRow has 86 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function simpleRow($shortname,$nicename,$cmd,$tab,$i)
          {
              $t_index = 'jobs';
              // if shortname is a task class name, switch indexes
              // and populate defaults if the task is not enabled
      Severity: Major
      Found in fannie/cron/management/CronManagementPage.php - About 3 hrs to fix

        Method run has 86 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function run()
            {
                $dbc = FannieDB::get($this->config->get('OP_DB'));
        
                $equityP = $dbc->prepare('
        Severity: Major
        Found in fannie/cron/tasks/SetMemDatesTask.php - About 3 hrs to fix

          Method newBatchInput has 86 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function newBatchInput()
              {
                  $dbc = FannieDB::get($this->config->get('OP_DB'));
                  $url = $this->config->get('URL');
          
          
          Severity: Major
          Found in fannie/batches/newbatch/BatchListPage.php - About 3 hrs to fix

            Method showPairedBatchDisplay has 86 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function showPairedBatchDisplay($id, $name)
                {
                    global $FANNIE_SERVER_DBMS;
                    $dbc = $this->connection;
                    $uid = getUID($this->current_user);
            Severity: Major
            Found in fannie/batches/newbatch/EditBatchPage.php - About 3 hrs to fix

              Method generateExtended_24UPTag has 86 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function generateExtended_24UPTag($x, $y, $guide, $width, $height, $pdf, $row, $dbc, $showPrice, $offset)
              {
                  $upc = $row['upc'];
                  $desc = $row['description'];
                  $brand = $row['brand'];
              Severity: Major
              Found in fannie/admin/labels/pdf_layouts/WFC_Dark_Extended_24UP.php - About 3 hrs to fix

                Method generateNarrow_24UPTag has 86 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function generateNarrow_24UPTag($x, $y, $guide, $width, $height, $pdf, $row, $dbc, $showPrice, $offset)
                {
                    $upc = $row['upc'];
                    $desc = $row['description'];
                    $brand = $row['brand'];
                Severity: Major
                Found in fannie/admin/labels/pdf_layouts/WFC_Deli_Narrow_24UP.php - About 3 hrs to fix

                  Method generateShort_24UPTag has 86 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function generateShort_24UPTag($x, $y, $guide, $width, $height, $pdf, $row, $dbc, $showPrice, $offset)
                  {
                      $upc = $row['upc'];
                      $desc = $row['description'];
                      $brand = $row['brand'];
                  Severity: Major
                  Found in fannie/admin/labels/pdf_layouts/WFC_Deli_Short_24UP.php - About 3 hrs to fix

                    Method WFC_Double has 86 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function WFC_Double($data,$offset=0){
                    
                    $pdf=new WFC_Double_PDF('P','mm','Letter'); //start new instance of PDF
                    $pdf->Open(); //open new PDF Document
                    $pdf->setTagDate(date("m/d/Y"));
                    Severity: Major
                    Found in fannie/admin/labels/pdf_layouts/WFC_Double.php - About 3 hrs to fix

                      Method fetch_report_data has 86 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function fetch_report_data()
                          {
                              global $FANNIE_PLUGIN_SETTINGS, $FANNIE_OP_DB;
                              $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['GiveUsMoneyDB']);
                      
                      

                        Method get_view has 86 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            protected function get_view()
                            {
                                $store = FormLib::get('store');
                                if (!$store) {
                                    $store = COREPOS\Fannie\API\lib\Store::getIdByIp();
                        Severity: Major
                        Found in fannie/modules/plugins2.0/ShelfAudit/SaAdjustmentsPage.php - About 3 hrs to fix

                          Method get_id_handler has 86 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              protected function get_id_handler()
                              {
                                  $ret = array();
                                  $settings = $this->config->get('PLUGIN_SETTINGS');
                                  if ($this->id !== '') {
                          Severity: Major
                          Found in fannie/modules/plugins2.0/ShelfAudit/SaHandheldPage.php - About 3 hrs to fix

                            Method css_content has 86 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function css_content()
                                {
                                    return <<<HTML
                            span.supertab {
                                padding: 2px;
                            Severity: Major
                            Found in fannie/item/ProdReviewPage.php - About 3 hrs to fix

                              Method To1bpp has 86 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public static byte[] To1bpp(string filename){
                                      byte[] data = System.IO.File.ReadAllBytes(filename);
                              
                                      int raw_loc = BitmapConverter.GetInt(data,0xa,0xd);
                                      int width = BitmapConverter.GetInt(data,0x12,0x15);
                              Severity: Major
                              Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/BitmapConverter.cs - About 3 hrs to fix

                                Function memberOnlyDept has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    private function memberOnlyDept($dept, $ret)
                                    {
                                        /**
                                          Enforce memberOnly flag
                                        */
                                Severity: Minor
                                Found in pos/is4c-nf/lib/DeptLib.php - About 3 hrs to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function filter has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function filter($dbc, $data)
                                    {
                                        $tenderTTL = 0.00;
                                        $tax = false;
                                        $discount = false;
                                Severity: Minor
                                Found in pos/is4c-nf/lib/ReceiptBuilding/Filter/InOrderReceiptFilter.php - About 3 hrs to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language