Showing 8,683 of 8,684 total issues
Identical blocks of code found in 2 locations. Consider refactoring. Open
while($itemsW = $dbc->fetch_row($itemsR)){
if (!isset($items[$itemsW['order_id']]))
$items[$itemsW['order_id']] = $itemsW['description'];
else
$items[$itemsW['order_id']] .= "; ".$itemsW['description'];
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 151.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
static public function code128($barcode, $forcePaper=false)
{
if (!is_object(self::$PRINT)) {
self::$PRINT= PrintHandler::factory(CoreLocal::get('ReceiptDriver'));
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 151.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
static public function code39($barcode, $forcePaper=false)
{
if (!is_object(self::$PRINT)) {
self::$PRINT= PrintHandler::factory(CoreLocal::get('ReceiptDriver'));
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 151.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method handleResponseAuth
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function handleResponseAuth($authResult)
{
$resp = $this->desoapify("GiftTransactionResult",
$authResult["response"]);
$xml = new BetterXmlData($resp);
Method head_content
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
function head_content()
{
?>
<style type="text/css">
/**
Method simpleRow
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function simpleRow($shortname,$nicename,$cmd,$tab,$i)
{
$t_index = 'jobs';
// if shortname is a task class name, switch indexes
// and populate defaults if the task is not enabled
Method run
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function run()
{
$dbc = FannieDB::get($this->config->get('OP_DB'));
$equityP = $dbc->prepare('
Method newBatchInput
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
function newBatchInput()
{
$dbc = FannieDB::get($this->config->get('OP_DB'));
$url = $this->config->get('URL');
Method showPairedBatchDisplay
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function showPairedBatchDisplay($id, $name)
{
global $FANNIE_SERVER_DBMS;
$dbc = $this->connection;
$uid = getUID($this->current_user);
Method generateExtended_24UPTag
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
function generateExtended_24UPTag($x, $y, $guide, $width, $height, $pdf, $row, $dbc, $showPrice, $offset)
{
$upc = $row['upc'];
$desc = $row['description'];
$brand = $row['brand'];
Method generateNarrow_24UPTag
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
function generateNarrow_24UPTag($x, $y, $guide, $width, $height, $pdf, $row, $dbc, $showPrice, $offset)
{
$upc = $row['upc'];
$desc = $row['description'];
$brand = $row['brand'];
Method generateShort_24UPTag
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
function generateShort_24UPTag($x, $y, $guide, $width, $height, $pdf, $row, $dbc, $showPrice, $offset)
{
$upc = $row['upc'];
$desc = $row['description'];
$brand = $row['brand'];
Method WFC_Double
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
function WFC_Double($data,$offset=0){
$pdf=new WFC_Double_PDF('P','mm','Letter'); //start new instance of PDF
$pdf->Open(); //open new PDF Document
$pdf->setTagDate(date("m/d/Y"));
Method fetch_report_data
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function fetch_report_data()
{
global $FANNIE_PLUGIN_SETTINGS, $FANNIE_OP_DB;
$dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['GiveUsMoneyDB']);
Method get_view
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function get_view()
{
$store = FormLib::get('store');
if (!$store) {
$store = COREPOS\Fannie\API\lib\Store::getIdByIp();
Method get_id_handler
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function get_id_handler()
{
$ret = array();
$settings = $this->config->get('PLUGIN_SETTINGS');
if ($this->id !== '') {
Method css_content
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function css_content()
{
return <<<HTML
span.supertab {
padding: 2px;
Method To1bpp
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static byte[] To1bpp(string filename){
byte[] data = System.IO.File.ReadAllBytes(filename);
int raw_loc = BitmapConverter.GetInt(data,0xa,0xd);
int width = BitmapConverter.GetInt(data,0x12,0x15);
Function memberOnlyDept
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
private function memberOnlyDept($dept, $ret)
{
/**
Enforce memberOnly flag
*/
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function filter
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
public function filter($dbc, $data)
{
$tenderTTL = 0.00;
$tax = false;
$discount = false;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"