Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
Aggregates/Scores/ScoresCommandHandlers.cs

Summary

Maintainability
C
1 day
Test Coverage

Method Handle has 192 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public IEnumerable Handle(Func<Guid, MatchAggregate> al, SaveMatchResult command)
        {
            var agg = al(command.Id);
            
            var match = _dispatcher.Load<MatchAggregate>(command.Id); //TODO: Why am I loading this again?
Severity: Major
Found in Aggregates/Scores/ScoresCommandHandlers.cs - About 7 hrs to fix

    File ScoresCommandHandlers.cs has 288 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    using Edument.CQRS;
using Events.Scores;
using MBACNationals.Participant;
using MBACNationals.Scores.Commands;
using System;
    Severity: Minor
    Found in Aggregates/Scores/ScoresCommandHandlers.cs - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      var awaySingleParticipant = CommandQueries.GetTeamParticipants(command.Away.Id)
                    .Where(x => !x.IsReplaced)
                    .OrderBy(x => x.QualifyingPosition)
                    .FirstOrDefault() ?? new CommandQueries.Participant();
      Severity: Minor
      Found in Aggregates/Scores/ScoresCommandHandlers.cs and 1 other location - About 45 mins to fix
      Aggregates/Scores/ScoresCommandHandlers.cs on lines 49..52

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      var homeSingleParticipant = CommandQueries.GetTeamParticipants(command.Home.Id)
                    .Where(x => !x.IsReplaced)
                    .OrderBy(x => x.QualifyingPosition)
                    .FirstOrDefault() ?? new CommandQueries.Participant();
      Severity: Minor
      Found in Aggregates/Scores/ScoresCommandHandlers.cs and 1 other location - About 45 mins to fix
      Aggregates/Scores/ScoresCommandHandlers.cs on lines 40..43

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status