CartoDB/Windshaft

View on GitHub

Showing 49 of 59 total issues

File leaflet.utfgrid.js has 325 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// https://github.com/danzel/Leaflet.utfgrid/blob/18b7043c4a8ac19d4a06658b26e165fb02b8cf1b/src/leaflet.utfgrid.js
// Copyright 2012 David Leaver
// MIT License
L.Util.ajax = function (url, timeout, success, error) {

Severity: Minor
Found in examples/viewer/leaflet.utfgrid.js - About 3 hrs to fix

    exports has 25 functions (exceeds 20 allowed). Consider refactoring.
    Open

    module.exports = class MapConfig {
        // Factory like method to create MapConfig objects when you are unsure about being
        // able to provide all the MapConfig collaborators or you have to create a MapConfig
        // object from a serialized version
        static create (rawConfig, datasource) {
    Severity: Minor
    Found in lib/models/mapconfig.js - About 2 hrs to fix

      File factory.js has 284 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict';
      
      const { rendererFactory: mapnikRendererFactory } = require('@carto/cartonik');
      const mapnik = require('@carto/mapnik');
      const grainstore = require('grainstore');
      Severity: Minor
      Found in lib/renderers/mapnik/factory.js - About 2 hrs to fix

        Function mapConfigToMMLBuilderConfig has 68 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function mapConfigToMMLBuilderConfig (mapConfig, rendererOptions, mapnikOptions) {
            const options = {
                ids: [],
                sql: [],
                originalSql: [],
        Severity: Major
        Found in lib/renderers/mapnik/factory.js - About 2 hrs to fix

          Function getTileData has 65 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              async getTileData (psql, coord, zoom, layerSql, attrs) {
                  let columnConv = attrs.column;
          
                  if (attrs.is_time) {
                      columnConv = format("date_part('epoch', {column})", attrs);
          Severity: Major
          Found in lib/renderers/torque/renderer.js - About 2 hrs to fix

            Function ajax has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
            Open

            L.Util.ajax = function (url, timeout, success, error) {
            
                if (window.XMLHttpRequest === undefined) {
                    error(new Error("XMLHttpRequest is not supported"));
                }
            Severity: Minor
            Found in examples/viewer/leaflet.utfgrid.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getRenderer has 59 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                getRenderer (mapConfig, format, options, callback) {
                    const isMvt = format === FORMAT_MVT;
            
                    if (mapConfig.isVectorOnlyMapConfig() && !isMvt) {
                        const error = new Error(`Unsupported format: 'cartocss' option is missing for ${format}`);
            Severity: Major
            Found in lib/renderers/mapnik/factory.js - About 2 hrs to fix

              UtfGrid has 21 functions (exceeds 20 allowed). Consider refactoring.
              Open

              L.UtfGrid = (L.Layer || L.Class).extend({
                  includes: L.Mixin.Events,
                  options: {
                      subdomains: 'abc',
              
              
              Severity: Minor
              Found in examples/viewer/leaflet.utfgrid.js - About 2 hrs to fix

                Function _update has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                Open

                    _update: function () {
                
                        var bounds = this._map.getPixelBounds(),
                            zoom = this._map.getZoom(),
                            tileSize = this.options.tileSize;
                Severity: Minor
                Found in examples/viewer/leaflet.utfgrid.js - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function constructor has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    constructor (layer, psql, attrs) {
                        const cartoCssOptions = torque.common.TorqueLayer.optionsFromCartoCSS(layer.options.cartocss);
                        const rendererOptions = {
                            bufferSize: cartoCssOptions['buffer-size'] !== undefined ? cartoCssOptions['buffer-size'] : 32
                        };
                Severity: Major
                Found in lib/renderers/torque/png-renderer.js - About 2 hrs to fix

                  Function getFeatureAttributes has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      getFeatureAttributes (mapConfigProvider, params, testMode, callback) {
                          const timer = new Timer();
                  
                          mapConfigProvider.getMapConfig((err, mapConfig) => {
                              if (err) {
                  Severity: Minor
                  Found in lib/backends/attributes.js - About 2 hrs to fix

                    Function getRenderer has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        getRenderer (mapConfig, format, options, callback) {
                            const layer = options.layer;
                            const params = options.params;
                            const limits = options.limits;
                    
                    
                    Severity: Minor
                    Found in lib/renderers/blend/factory.js - About 1 hr to fix

                      Function getRenderer has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                      Open

                          getRenderer (mapConfig, format, options, callback) {
                              const layer = options.layer;
                              const params = options.params;
                              const limits = options.limits;
                      
                      
                      Severity: Minor
                      Found in lib/renderers/blend/factory.js - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function getLayerColumns has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function getLayerColumns (psql, layer) {
                          return new Promise((resolve, reject) => {
                              if (layer._mvtColumns) {
                                  return resolve();
                              }
                      Severity: Minor
                      Found in lib/renderers/pg-mvt/renderer.js - About 1 hr to fix

                        Function validate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            validate (mapConfigProvider, callback) {
                                mapConfigProvider.getMapConfig((err, mapConfig, params) => {
                                    if (err) {
                                        return callback(err, false);
                                    }
                        Severity: Minor
                        Found in lib/backends/map-validator.js - About 1 hr to fix

                          Function getMetadata has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              getMetadata (rendererCache, params, mapConfig, callback) {
                                  const metadataParams = mapConfig.getLayers()
                                      .map((layer, layerId) => {
                                          const getMetadata = this.getLayerMetadataFn(mapConfig, layerId);
                                          return getMetadata ? { getMetadata, mapConfig, layer, layerId, params, rendererCache } : null;
                          Severity: Minor
                          Found in lib/metadata/layer-metadata.js - About 1 hr to fix

                            Function attrsFromCartoCSS has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function attrsFromCartoCSS (cartocss, required) {
                                const attrsKeys = {
                                    '-torque-frame-count': 'steps',
                                    '-torque-resolution': 'resolution',
                                    '-torque-animation-duration': 'animationDuration',
                            Severity: Minor
                            Found in lib/renderers/torque/factory.js - About 1 hr to fix

                              Function _move has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  _move: function (e) {
                                      var on = this._objectForEvent(e);
                              
                                      if (on.data !== this._mouseOn) {
                                          if (this._mouseOn) {
                              Severity: Minor
                              Found in examples/viewer/leaflet.utfgrid.js - About 1 hr to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function getTile has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  getTile (mapConfigProvider, params, callback) {
                                      const { format, interactivity, token, z, x, y } = params;
                              
                                      // TODO: review if needed see cartonik's validations
                                      if (format === 'grid.json' && !interactivity) {
                              Severity: Minor
                              Found in lib/backends/tile.js - About 1 hr to fix

                                Function getRenderer has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    getRenderer (mapConfig, format, options, callback) {
                                        if (mapConfig.isVectorOnlyMapConfig() && format !== PgMvtFactory.MVT_FORMAT) {
                                            const error = new Error(`Unsupported format: 'cartocss' option is missing for ${format}`);
                                            error.http_status = 400;
                                            error.type = 'tile';
                                Severity: Minor
                                Found in lib/renderers/pg-mvt/factory.js - About 1 hr to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language