Sign upLogin

CellProfiler/centrosome

View on GitHub
Star
centrosome/smooth.py

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    i, j = np.mgrid[-radius : radius + 1, -radius : radius + 1].astype(float) / radius
Severity: Major
Found in centrosome/smooth.py and 2 other locations - About 1 hr to fix
centrosome/filter.py on lines 280..280
centrosome/filter.py on lines 781..781

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    x, y = np.mgrid[0 : pixel_data.shape[0], 0 : pixel_data.shape[1]]
Severity: Major
Found in centrosome/smooth.py and 7 other locations - About 1 hr to fix
centrosome/bg_compensate.py on lines 447..447
centrosome/cpmorphology.py on lines 2312..2312
centrosome/cpmorphology.py on lines 4188..4188
centrosome/cpmorphology.py on lines 4259..4259
centrosome/cpmorphology.py on lines 5176..5176
centrosome/filter.py on lines 1626..1626
centrosome/filter.py on lines 1976..1976

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status