Sign upLogin

Cellarise/istanbul-reporter-clover-limits

View on GitHub
Star

Showing 58 of 58 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (branchesPercent < limits.branches) {
      result.error = result.error + "Insufficient branch coverage: actual=" + branchesPercent * 100 +
        "% required=" + limits.branches * 100 +
        "% (branches covered = " + metrics.branches.covered +
        " total branches = " + metrics.branches.total + ")" +
Severity: Major
Found in lib/clover-limits.js and 1 other location - About 3 hrs to fix
lib/clover-limits.js on lines 135..141

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File clover-limits.js has 295 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";
var path = require("path");
var Report = require("istanbul").Report;
var FileWriter = require("./util/file-writer");
var TreeSummarizer = require("istanbul").TreeSummarizer;
Severity: Minor
Found in lib/clover-limits.js - About 3 hrs to fix

    Function testSuite has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = (function testSuite() {
  var fs = require("fs");
  var path = require("path");
  var gulp = require("gulp");
  var glob = require("glob");
    Severity: Major
    Found in Test/functional/Package-MDCOVSM-3-steps.js - About 3 hrs to fix

      File test.js has 290 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      "use strict";
/**
 * A module to add gulp tasks which run test steps.
 * @exports tasks/testTasks
 * @param {Gulp} gulp - The gulp module
      Severity: Minor
      Found in tasks/test.js - About 2 hrs to fix

        Function test has 67 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          var test = function test(reporter, outputCoverageReports) {
    var cwd = context.cwd;
    var pkg = context.package;
    var directories = pkg.directories;
    var sourceGlobStr = directories.lib + "/**/*.js";
        Severity: Major
        Found in tasks/test.js - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              "before": function b(before, worldContext) {
      before(function beforeFn(done) {
        if (worldContext.world.hasOwnProperty("before")) {
          worldContext.world.before(done);
          delete worldContext.world.before;
          Severity: Major
          Found in Test/testUtils.js and 1 other location - About 2 hrs to fix
          Test/testUtils.js on lines 125..134

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 86.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              "after": function a(after, worldContext) {
      after(function afterFn(done) {
        if (worldContext.world.hasOwnProperty("after")) {
          worldContext.world.after(done);
          delete worldContext.world.after;
          Severity: Major
          Found in Test/testUtils.js and 1 other location - About 2 hrs to fix
          Test/testUtils.js on lines 115..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 86.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function addClassStats has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

          var addClassStats = function addClassStats(node, fileCoverage, writer, jsonResults, limits) {
  var metrics = node.metrics,
    branchByLine = branchCoverageByLine(fileCoverage),
    //funcMap,
    lines,
          Severity: Minor
          Found in lib/clover-limits.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  coverageStat.overall.pct =
          Math.round((coverageStat.lines.pct +
          coverageStat.branches.pct +
          coverageStat.statements.pct +
          coverageStat.functions.pct) / 400 * 100);
          Severity: Major
          Found in tasks/lib/coverageStats.js and 1 other location - About 2 hrs to fix
          tasks/lib/coverageStats.js on lines 113..116

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  coverageStat.skipped.pct = Math.round((coverageStat.lines.pctSkipped +
        coverageStat.branches.pctSkipped +
        coverageStat.statements.pctSkipped +
        coverageStat.functions.pctSkipped) / 400 * 100);
          Severity: Major
          Found in tasks/lib/coverageStats.js and 1 other location - About 2 hrs to fix
          tasks/lib/coverageStats.js on lines 127..131

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function calculateCoverageStats has 52 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              "calculateCoverageStats": function calculateCoverageStats(coverageReport, packageJSON) {
      var coverageStat = {
        "lines": {"total": 0, "covered": 0, "skipped": 0},
        "branches": {"total": 0, "covered": 0, "skipped": 0},
        "statements": {"total": 0, "covered": 0, "skipped": 0},
          Severity: Major
          Found in tasks/lib/coverageStats.js - About 2 hrs to fix

            Consider simplifying this complex logical expression.
            Open

                  if (coverageReport && packageJSON) {
        for (coveredFile in coverageReport) {
          if (coverageReport.hasOwnProperty(coveredFile)) {
            this.addStats(coverageStat, coverageReport[coveredFile]);
          }
            Severity: Critical
            Found in tasks/lib/coverageStats.js - About 2 hrs to fix

              Function openBrowser has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  "openBrowser": function openBrowser(worldContext, done) {
      var requestStream;
      var browser = this.browsers.length > 0 ? this.browsers[0] : null;
      var subLogger = worldContext.world.logger.child({"widget_type": 'LOOPBACK'});
      var Bacon, Server, server, Command, request;
              Severity: Minor
              Found in Test/testUtils.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    "beforeAll": function b(beforeAll, worldContext) {
      if (!beforeAllFlag) {
        beforeAllFlag = true;
        beforeAll(function beforeFn(done) {
          this.openBrowser(worldContext, done);
                Severity: Major
                Found in Test/testUtils.js and 1 other location - About 1 hr to fix
                Test/testUtils.js on lines 107..114

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    "afterAll": function a(afterAll, worldContext) {
      if (!afterAllFlag) {
        afterAllFlag = true;
        afterAll(function afterFn(done) {
          this.closeBrowser(worldContext, done);
                Severity: Major
                Found in Test/testUtils.js and 1 other location - About 1 hr to fix
                Test/testUtils.js on lines 99..106

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function writeReport has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  "writeReport": function writeReport(collector, sync) {
    var summarizer = new TreeSummarizer(),
      outputFile = path.join(this.dir, this.file),
      jsonOutputFile = path.join(this.testDir, this.testFile),
      writer = this.opts.writer || new FileWriter(sync),
                Severity: Minor
                Found in lib/clover-limits.js - About 1 hr to fix

                  Function closeBrowser has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      "closeBrowser": function closeBrowser(worldContext, done) {
      var browser = this.browsers.length > 0 ? this.browsers[0] : null;
      if (browser && worldContext.browser.remote) { //if .remote exists then web server and browser available to kill
        worldContext.browser.request(_opts.url + '/coverage', function handler(error, response, body) {
          var vasync = require('vasync');
                  Severity: Minor
                  Found in Test/testUtils.js - About 1 hr to fix

                    Function coverageStatsTasks has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    module.exports = function coverageStatsTasks(gulp, context) {
  var jeditor = require("gulp-json-editor");
  var gutil = require("gulp-util");
  var logger = context.logger;
  var fs = require("fs");
                    Severity: Minor
                    Found in tasks/coverageStats.js - About 1 hr to fix

                      Function test has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          .define("When I run coverage report on the files", function test(done) {
      var logger = this.world.logger;
      var COVERAGE_VARIABLE = "$$1cov_" + new Date().getTime() + "$$";

      gulp.src(["Test_Resources/resources/non-bundled/**/*.js"])
                      Severity: Minor
                      Found in Test/functional/Package-MDCOVSM-3-steps.js - About 1 hr to fix

                        Function coverageStatsTasks has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                        module.exports = function coverageStatsTasks(gulp, context) {
  var jeditor = require("gulp-json-editor");
  var gutil = require("gulp-util");
  var logger = context.logger;
  var fs = require("fs");
                        Severity: Minor
                        Found in tasks/coverageStats.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language