Sign upLogin

CenterForOpenScience/waterbutler

View on GitHub
Star
waterbutler/server/api/v1/provider/__init__.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function on_finish has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def on_finish(self):
        status, method = self.get_status(), self.request.method.upper()

        # If the response code is not within the 200-302 range, the request was a HEAD or OPTIONS,
        # the response code is 202, or the response was a 206 partial request, then no callbacks
Severity: Minor
Found in waterbutler/server/api/v1/provider/__init__.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _send_hook has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def _send_hook(self, action):
        source = None
        destination = None

        if action in ('move', 'copy'):
Severity: Minor
Found in waterbutler/server/api/v1/provider/__init__.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status