Sign upLogin

ChaelCodes/HuntersKeepers

View on GitHub
Star
app/controllers/hunters_improvements_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage

Method has too many lines. [20/10]
Invalid

  def create
    @hunters_improvement = HuntersImprovement.new(hunters_improvement_params)
    @hunters_improvement.hunter = @hunter
    update_improvable_option
    authorize @hunters_improvement
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [17/10]
Invalid

  def update
    respond_to do |format|
      update_improvable_option
      if @hunters_improvement.update(hunters_improvement_params)
        format.html do
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for create is too high. [21.19/15]
Wontfix

  def create
    @hunters_improvement = HuntersImprovement.new(hunters_improvement_params)
    @hunters_improvement.hunter = @hunter
    update_improvable_option
    authorize @hunters_improvement
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric and https://en.wikipedia.org/wiki/ABC_Software_Metric.

Assignment Branch Condition size for update is too high. [19.1/15]
Wontfix

  def update
    respond_to do |format|
      update_improvable_option
      if @hunters_improvement.update(hunters_improvement_params)
        format.html do
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric and https://en.wikipedia.org/wiki/ABC_Software_Metric.

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

        format.html do
          redirect_to hunter_hunters_improvement_url(hunter_id: @hunter.id, id: @hunters_improvement.id),
                      notice: 'Hunters improvement was successfully created.'
        end
        format.json do
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb and 1 other location - About 30 mins to fix
app/controllers/hunters_improvements_controller.rb on lines 61..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

        format.html do
          redirect_to hunter_hunters_improvement_url(hunter_id: @hunter.id, id: @hunters_improvement.id),
                      notice: 'Hunters improvement was successfully updated.'
        end
        format.json do
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb and 1 other location - About 30 mins to fix
app/controllers/hunters_improvements_controller.rb on lines 39..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line is too long. [95/80]
Open

        format.json { render json: @hunters_improvement.errors, status: :unprocessable_entity }
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

Line is too long. [107/80]
Open

    @hunters_improvement.improvement = Improvement.find(params[:improvement_id]) if params[:improvement_id]
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

Line is too long. [109/80]
Open

                 location: hunter_hunters_improvement_url(hunter_id: @hunter.id, id: @hunters_improvement.id)
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

Keep a blank line before and after private.
Wontfix

  private
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

Access modifiers should be surrounded by blank lines.

Example: EnforcedStyle: around (default)

# bad
class Foo
  def bar; end
  private
  def baz; end
end

# good
class Foo
  def bar; end

  private

  def baz; end
end

Example: EnforcedStyle: only_before

# bad
class Foo
  def bar; end
  private
  def baz; end
end

# good
class Foo
  def bar; end

  private
  def baz; end
end

Line is too long. [105/80]
Open

          redirect_to hunter_hunters_improvement_url(hunter_id: @hunter.id, id: @hunters_improvement.id),
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

Line is too long. [109/80]
Open

                 location: hunter_hunters_improvement_url(hunter_id: @hunter.id, id: @hunters_improvement.id)
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

Line is too long. [110/80]
Open

        redirect_to hunter_hunters_improvements_url, notice: 'Hunters improvement was successfully destroyed.'
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

Line is too long. [105/80]
Open

          redirect_to hunter_hunters_improvement_url(hunter_id: @hunter.id, id: @hunters_improvement.id),
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

Line is too long. [95/80]
Open

        format.json { render json: @hunters_improvement.errors, status: :unprocessable_entity }
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

There are no issues that match your filters.

Category
Status